Implement reinit! for DualLinearCache #844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the missing reinit! method for the DualLinearCache type, which is needed when using ForwardDiff with LinearSolve and wanting to update the cache values without creating a new cache. The implementation directly mutates the cache fields (following the same pattern as the regular LinearCache reinit! method) rather than using the setX! helper functions. Closes SciML#836 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reinit!method forDualLinearCacheLinearCachereinit!) instead ofsetX!helper functionsdual_A,dual_b,dual_u,partials_A,partials_b,partials_u, andpartials_*_listcachesChecklist
Additional context
This completes the work started in #836, implementing the
reinit!method using direct mutation instead of thesetX!helper functions, matching the pattern used in the regularLinearCachereinit! implementation.Tests verify:
Closes #836
🤖 Generated with Claude Code