Fix strict QA follow-ups after #640 - #641
Closed
ChrisRackauckas-Claude wants to merge 2 commits into
Closed
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Comment on lines
-8
to
-10
| [sources] | ||
| RecursiveArrayTools = {path = "../.."} | ||
|
|
| @@ -1,5 +1,7 @@ | |||
| using RecursiveArrayTools, RecursiveArrayToolsArrayPartitionAnyAll, Test | |||
| using Pkg | |||
| Pkg.develop(PackageSpec(path = normpath(joinpath(@__DIR__, "..", "..", "..")))) | |||
Member
There was a problem hiding this comment.
Don't do this, use sources.
| fill!(VA[:, i], x) | ||
| else | ||
| # For immutable arrays like SVector, create a new filled array | ||
| VA.u[i] = fill(x, StaticArraysCore.similar_type(VA.u[i])) |
Member
There was a problem hiding this comment.
StaticArraysCore.similar_type should be allowed.
Member
|
All of the changes in this PR are just wrong and unnecessary. |
Member
Author
|
Closed because the changes are unnecessary and should not be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until reviewed by @ChrisRackauckas.
Summary
[sources]path overrides from monorepo test environmentsThe pre-existing root-package ambiguity exception remains narrowly scoped. The underlying ambiguity families and their introducing commits are recorded in #326; this PR does not hide any new QA failure.
Local verification
git diff --checkpassedCo-Authored-By: Chris Rackauckas accounts@chrisrackauckas.com