Repository navigation
Raise ArrayInterface compat floor to 7.1 (fix downgrade CI) - #40
Merged
ChrisRackauckas merged 1 commit intoJun 15, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
The downgrade CI pins ArrayInterface to its compat floor (7.0.0). At
7.0.0, `ArrayInterface.fast_scalar_indexing(::JLArray)` returns `true`
because the GPUArraysCore-aware definition that correctly reports `false`
for GPU-backed arrays was only added in ArrayInterface 7.1.0.
As a result the `_require_fast_scalar_indexing` guard never fires on the
downgrade floor: the package proceeds to scalar-index the GPU array and
GPUArrays throws a plain `ErrorException` ("Scalar indexing is
disallowed.") instead of the package's intended `ArgumentError`. This
breaks the `JLArray error messages` testset, which asserts an
`ArgumentError` mentioning "fast scalar indexing" / "GPU arrays".
The package's documented behavior (rejecting GPU arrays with a clear
`ArgumentError`) only holds from ArrayInterface 7.1.0 onward, so 7.1 is
the correct minimum bound.
Verified locally on Julia 1.10.11: with ArrayInterface 7.1.0 + JLArrays
0.1.1 (the downgrade floor for JLArrays), all 8 assertions in the
"JLArray error messages" testset pass; at 7.0.0 they fail exactly as in
CI.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
marked this pull request as ready for review
June 15, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
downgrade / Downgrade Testscheck onmainis red. The downgrade job pinsArrayInterfaceto its compat floor (7.0.0). At7.0.0,ArrayInterface.fast_scalar_indexing(::JLArray)returnstruebecause the GPUArraysCore-aware definition that correctly reportsfalsefor GPU-backed arrays was only added inArrayInterface7.1.0.As a result, the
_require_fast_scalar_indexingguard never fires on the downgrade floor: the package proceeds to scalar-index the GPU array, and GPUArrays throws a plainErrorException("Scalar indexing is disallowed.") instead of the package's intendedArgumentError. This breaks theJLArray error messagestestset intest/interface_compatibility_tests.jl, which asserts anArgumentErrormentioning "fast scalar indexing" / "GPU arrays".Fix
Raise the
ArrayInterfacecompat floor from"7"to"7.1". The package's documented behavior (rejecting GPU arrays with a clearArgumentError) only holds fromArrayInterface7.1.0onward, so7.1is the correct minimum bound.Verification (local, Julia 1.10.11)
Bisected
ArrayInterfaceagainstJLArrays 0.1.1(the downgrade floor for JLArrays):With
ArrayInterface 7.1.0+JLArrays 0.1.1, all 8 assertions in the "JLArray error messages" testset pass:Please ignore until reviewed by @ChrisRackauckas.