Skip to content

QA: run_qa v1.6 form + ExplicitImports #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 27, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ BlockBandedMatrices = "0.13.4"
FastAlmostBandedMatrices = "0.1.5"
GPUArrays = "8.4, 9, 10, 11"
JLArrays = "0.1, 0.2, 0.3"
LinearAlgebra = "1"
SafeTestsets = "0.0.1, 0.1, 1"
SciMLTesting = "1"
SemiseparableMatrices = "0.4.0"
SparseArrays = "1"
SpecialMatrices = "3.1.0"
Test = "1"
ToeplitzMatrices = "0.8.5"
Expand Down
7 changes: 4 additions & 3 deletions src/SparseMatrixIdentification.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module SparseMatrixIdentification
using LinearAlgebra
using SparseArrays
using ArrayInterface
using LinearAlgebra: Hermitian, LowerTriangular, Symmetric, UpperTriangular,
ishermitian, issymmetric, istril, istriu, svdvals
using SparseArrays: AbstractSparseMatrix, SparseMatrixCSC, nonzeros
using ArrayInterface: ArrayInterface

# Helper function to check if an array supports fast scalar indexing
function _require_fast_scalar_indexing(A, funcname)
Expand Down
4 changes: 1 addition & 3 deletions test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
SparseMatrixIdentification = "2607229e-3272-44a7-bc4a-cd97a328dfbf"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand All @@ -12,7 +11,6 @@ SparseMatrixIdentification = {path = "../.."}
[compat]
Aqua = "0.8"
JET = "0.9,0.10,0.11"
SafeTestsets = "0.0.1, 0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"
23 changes: 10 additions & 13 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
using SparseMatrixIdentification
using Aqua
using SciMLTesting, SparseMatrixIdentification, Test
using JET
using Test

@testset "Aqua" begin
# deps_compat is a genuine finding (missing compat for LinearAlgebra/SparseArrays
# deps and the Pkg extra); keep every other sub-check enabled.
Aqua.test_all(SparseMatrixIdentification; deps_compat = false)
@test_broken false # Aqua deps_compat: missing compat for LinearAlgebra, SparseArrays, Pkg — see https://github.com/SciML/SparseMatrixIdentification.jl/issues/36
end

@testset "JET" begin
@test_broken false # JET: try_* extension helpers report no-matching-method in sparsestructure(::AbstractSparseMatrix) — see https://github.com/SciML/SparseMatrixIdentification.jl/issues/36
end
run_qa(
SparseMatrixIdentification;
explicit_imports = true,
ei_kwargs = (;
# `fast_scalar_indexing` is not public (unexported, not declared public) in
# ArrayInterface; it is the only non-public name this package accesses.
all_qualified_accesses_are_public = (; ignore = (:fast_scalar_indexing,)),
),
)
Loading