Fix/remove standalone metal shader#1331
Merged
martindevans merged 2 commits intoSciSharp:masterfrom Feb 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had
-DLLAMA_METAL_EMBED_LIBRARY=ONin the compile workflow since early 2024 (ede2c25)However, this meant that the shaders were always embedded into the dylib. For this reason, they stopped copying the shaders on the llama.cpp side if
-DLLAMA_METAL_EMBED_LIBRARY=ONwas set, because it was never needed in the first place (see this PR from January 6 2026).So previous binary update (August 2025) went ok, but latest one (yesterday) failed due to that recent change on the llama.cpp side, and this change should fix it, but would be nice if someone could test that metal still works after this change.