aegisub@3.4.2: Persist more files

[SiriosDev]

Dynamically add to the persist all JSON configuration files that are placed by automations directly in the app's root directory

• Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
• I have read the Contributing Guide

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b0696fb-2f75-426d-8c8d-6864eca72334

📥 Commits

Reviewing files that changed from the base of the PR and between b1624c7 and b5216fc.

📒 Files selected for processing (1)

• bucket/aegisub.json

🚧 Files skipped from review as they are similar to previous changes (1)

• bucket/aegisub.json

---

📝 Walkthrough

Walkthrough

The Aegisub manifest now copies all JSON files during pre-install. During pre-uninstall, it creates the persistence directory and copies JSON files except manifest.json and install.json. The pre-uninstall copy no longer uses an explicit force-overwrite option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b5216

This change updates package persistence behavior, and no actionable merge-blocking risk remains based on the supplied evidence; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the main change and follows the repository's conventional manifest-and-summary format.
Description check	✅ Passed	The description summarizes the persistence change and completes both required checklist items; no issue reference is provided.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/aegisub.json`:
- Around line 21-23: Restrict both the pre_uninstall persistence enumeration and
the pre_install restoration enumeration to root-level JSON files only, using a
*.json filter or the existing supported-configuration allow-list. Preserve
persistence for configuration JSON while excluding executables, DLLs,
documentation, and other package files; verify with a clean install, uninstall,
and reinstall.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b2fee834-ab29-4b78-a4f5-935220c96442

📥 Commits

Reviewing files that changed from the base of the PR and between 1cef1d1 and 1e99c9d.

📒 Files selected for processing (1)

• bucket/aegisub.json

[SiriosDev]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

aegisub

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[SiriosDev]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

aegisub

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[z-Fng]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

aegisub

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[SiriosDev]

Wait,

Edit:

okay, never mind, the email notification was formatted incorrectly and I noticed a problem, but everything looks fine in the web UI