look: Add version 0.6.10 - #18497
Conversation
|
/verify |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Scoop manifest for Look version 0.6.10. The manifest defines package metadata, WebView2 guidance, the 64-bit installer URL and checksum, post-install cleanup, shortcut creation, GitHub version detection, and versioned autoupdate URLs. Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
the
package-request-needed
|
All changes look good. Wait for review from human collaborators. look
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
bucket/look.json (2)
20-24: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winExpose the documented
lookappcommand through Scoop.The upstream Windows documentation supports launching
lookappfrom a terminal. Scoop usesbinentries to make programs available onPATH, but this manifest defines only a shortcut. Add abinentry after confirming the extraction path. (raw.githubusercontent.com)Proposed change
"post_install": "Remove-Item \"$dir\\`$*\" -Recurse -Force -ErrorAction SilentlyContinue", + "bin": "lookapp.exe", "shortcuts": [🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/look.json` around lines 20 - 24, Add a Scoop `bin` entry in the manifest alongside the existing `shortcuts` configuration, targeting the extracted `lookapp.exe` path so the documented `lookapp` command is available on PATH. Confirm the archive extraction layout before choosing the executable path, and preserve the existing shortcut.
1-39: 📐 Maintainability & Code Quality | 🔵 TrivialRun the manifest checks and verify CRLF line endings.
Run these commands from the repository root:
Local validation
scoop config debug true scoop config gh_token <your-github-token> # Read access only; optional .\bin\checkver.ps1 -App look -f .\bin\formatjson.ps1 -App look .\bin\checkhashes.ps1 look .\bin\checkurls.ps1 look scoop install .\bucket\look.json -a 64bit $text = [Text.Encoding]::UTF8.GetString([IO.File]::ReadAllBytes('bucket/look.json')) if ($text -match "(?<!`r)`n") { throw 'bucket/look.json must use CRLF line endings' }After installation, verify that
lookapp.exeexists, the Start-menu shortcut opens the application, andAlt+Spaceworks.As per path instructions: Scoop manifests must use CRLF and must pass version, formatting, hash, URL, and architecture-specific installation checks.
References:
https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md;https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/look.json` around lines 1 - 39, Run the specified Scoop validation commands for the look manifest, format it if needed, and ensure bucket/look.json uses CRLF line endings. Confirm version, hash, URL, and 64-bit installation checks pass, then verify lookapp.exe, the Start-menu shortcut, and Alt+Space functionality after installation.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/look.json`:
- Line 5: Update the license value in the manifest from GPL-3.0-only to the SPDX
variant GPL-3.0-or-later, preserving the rest of the manifest unchanged.
---
Nitpick comments:
In `@bucket/look.json`:
- Around line 20-24: Add a Scoop `bin` entry in the manifest alongside the
existing `shortcuts` configuration, targeting the extracted `lookapp.exe` path
so the documented `lookapp` command is available on PATH. Confirm the archive
extraction layout before choosing the executable path, and preserve the existing
shortcut.
- Around line 1-39: Run the specified Scoop validation commands for the look
manifest, format it if needed, and ensure bucket/look.json uses CRLF line
endings. Confirm version, hash, URL, and 64-bit installation checks pass, then
verify lookapp.exe, the Start-menu shortcut, and Alt+Space functionality after
installation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e3438e4f-10cd-4dca-bb63-ea07be10acca
📒 Files selected for processing (1)
bucket/look.json
aliesbelik
removed
the
package-request-needed
|
@dont-wait Thanks for doing this. Hash and shortcut target both check out, and the webview2 suggestion is a good catch. One flag, my bug not yours, don't hold the PR for it: Also, I'd skip two of the CodeRabbit nitpicks: no bin (GUI app, lookapp in our README is the Linux .deb binary), and the CRLF one is wrong since |
|
/verify |
|
All changes look good. Wait for review from human collaborators. look
|
|
@aliesbelik We really appreciate your support in bringing Look to Scoop❤️. We couldn't have achieved this milestone without your help. Many Thanks ❤️🔥🙏 |
3 participants
Closes #18496
Summary
lookmanifest for the published 64-bit Windows release#/dl.7zwith the published checksum fileextras/webview2and includecheckver/autoupdateValidation
./bin/checkhashes.ps1 look./bin/checkver.ps1 look./bin/checkurls.ps1 look