yazses: Add version 2.17.0 - #18498
Conversation
📝 WalkthroughWalkthroughAdded a Scoop manifest for YazSes 2.17.0. The manifest defines package metadata, a Windows 64-bit installer URL and hash, Inno Setup handling, a shortcut, GitHub version checking, and an autoupdate URL template. Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
not-meet-criteria
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/yazses.json (1)
8-18: 🩺 Stability & Availability | 🔵 TrivialTest the 64-bit installation before merge.
The installer extraction and
YazSes.exeshortcut were not tested on Windows. Run the required checks from the repository root:scoop config debug true scoop config gh_token <your-github-token> # Read access only .\bin\checkver.ps1 -App yazses -f .\bin\formatjson.ps1 -App yazses scoop install bucket/yazses.json -a 64bitConfirm that installation completes,
YazSes.exeexists in the extracted directory, and the shortcut launches the application.As per path instructions, test version detection, formatting, and installation for each supported architecture before submission.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/yazses.json` around lines 8 - 18, Validate the yazses manifest’s 64-bit installation from the repository root using the specified Scoop debug, version-check, formatting, and installation commands. Confirm extraction succeeds, YazSes.exe exists, and the configured shortcut launches the application; repeat version detection, formatting, and installation checks for every supported architecture before merge.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/yazses.json`:
- Around line 1-5: Before merging, add a valid Scoop package-request issue
number or URL to the pull request description, created using the provided
package-request template, and confirm the package satisfies new-package
acceptance criteria including the 100-star GitHub threshold; no manifest changes
are required.
---
Nitpick comments:
In `@bucket/yazses.json`:
- Around line 8-18: Validate the yazses manifest’s 64-bit installation from the
repository root using the specified Scoop debug, version-check, formatting, and
installation commands. Confirm extraction succeeds, YazSes.exe exists, and the
configured shortcut launches the application; repeat version detection,
formatting, and installation checks for every supported architecture before
merge.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1801cd38-6a3b-43c3-8ac1-1444cf3285c3
📒 Files selected for processing (1)
bucket/yazses.json
| { | ||
| "version": "2.17.0", | ||
| "description": "Offline hold-to-talk voice dictation that types into any focused app", | ||
| "homepage": "https://mskazemi.com/yazses/", | ||
| "license": "Apache-2.0", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -eu
file="bucket/yazses.json"
printf '%s\n' '--- repository state ---'
git status --short -- "$file"
git diff --stat -- "$file"
git diff --numstat -- "$file"
printf '%s\n' '--- manifest ---'
cat -n "$file"
printf '%s\n' '--- line endings ---'
python3 - <<'PY'
from pathlib import Path
p = Path("bucket/yazses.json").read_bytes()
print({
"bytes": len(p),
"crlf": p.count(b"\r\n"),
"lf": p.count(b"\n"),
"bare_lf": p.count(b"\n") - p.count(b"\r\n"),
})
PY
printf '%s\n' '--- manifest structure and versioned values ---'
python3 - <<'PY'
import json
from pathlib import Path
data = json.loads(Path("bucket/yazses.json").read_text())
print("keys:", list(data))
print("version:", data.get("version"))
print("url:", data.get("url"))
print("architecture:", data.get("architecture"))
print("autoupdate:", data.get("autoupdate"))
print("suggest:", data.get("suggest"))
PY
printf '%s\n' '--- package-request references in repository text ---'
rg -n -i 'package.?request|MSKazemi/yazses|yazses' . --glob '!bucket/yazses.json' || true
printf '%s\n' '--- GitHub repository metadata ---'
curl -fsSL -H 'Accept: application/vnd.github+json' \
https://api.github.com/repos/MSKazemi/yazses |
python3 -c 'import json,sys; d=json.load(sys.stdin); print({k:d.get(k) for k in ("full_name","stargazers_count","archived","license","default_branch")})'Repository: ScoopInstaller/Extras
Length of output: 2709
Add a package-request issue reference before merge.
The manifest uses valid CRLF line endings, and its versioned download URL is correctly parameterized with $version in autoupdate.
The available repository content contains no package-request issue reference. Add a valid issue number or issue URL to the PR description. Proceed only if the package meets the required new-package acceptance criteria, including the 100-star threshold for GitHub projects.
Create the issue at:
https://github.com/ScoopInstaller/Extras/issues/new?labels=package-request&template=package-request.yml&title=%5BRequest%5D%3A+
See the contribution guide and App Manifests wiki.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/yazses.json` around lines 1 - 5, Before merging, add a valid Scoop
package-request issue number or URL to the pull request description, created
using the provided package-request template, and confirm the package satisfies
new-package acceptance criteria including the 100-star GitHub threshold; no
manifest changes are required.
Sources: Path instructions, Learnings, MCP tools
|
Withdrawing this — I submitted it without following your process, and on checking properly it does not meet the bucket's criteria. Two things I got wrong:
The manifest itself is fine as far as I can tell — Inno Setup handling, verified SHA256, GitHub Sorry for the noise, and thanks for the automated checks that caught it. |
1 participant
Adds YazSes — an Apache-2.0 offline voice dictation app. Hold a key, speak, release, and the text is typed into whatever window has focus. Speech recognition runs locally via faster-whisper; no cloud service or account involved.
Manifest notes
"innosetup": truewith the#/dl.7zURL fragment, following the existing convention in this bucket.hashwas computed from the published assetYazSes-2.17.0-windows-x64.exe(99,848,444 bytes).YazSes.exe(console=False), which Inno installs to{app}. So this declaresshortcutsonly — abinshim would be misleading for a GUI-only executable.checkveruses the GitHub strategy andautoupdatefollows the stableYazSes-$version-windows-x64.exeasset naming.Upfront: the installer is unsigned — it is built in CI by Inno Setup from the public repo, but there is no code-signing certificate yet, so SmartScreen will warn on first run. Also note I do not have a Windows machine to hand, so I have not personally run
scoop installagainst this manifest; the schema and hash are verified, but the install itself is unproven by me. Happy to fix anything the bucket's checks flag.