localsend@1.18.0: Add arm64 support - #18503
Conversation
📝 WalkthroughWalkthroughThe LocalSend package definition now supports Windows ARM64 downloads. It includes the v1.18.0 ARM64 archive URL and SHA-256 hash. The autoupdate configuration also generates the ARM64 download URL from the package version. Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/localsend.json (1)
10-13: 🗄️ Data Integrity & Integration | 🔵 TrivialValidate both architecture paths before merge.
Run the manifest checks and installation tests in clean environments, or uninstall between architecture tests:
scoop config debug true .\bin\checkver.ps1 -App localsend -f .\bin\formatjson.ps1 -App localsend scoop install bucket/localsend.json -a 64bit scoop install bucket/localsend.json -a arm64Confirm that the committed manifest uses CRLF line endings.
As per path instructions, force version detection, auto-format the manifest, and test installation for each supported architecture before submission.
Also applies to: 37-39
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/localsend.json` around lines 10 - 13, Validate the localsend manifest across both 64bit and arm64 architectures by forcing version detection, auto-formatting it, and running clean-environment installation tests (or uninstalling between tests). Ensure the committed bucket/localsend.json uses CRLF line endings and includes the resulting validated formatting and metadata.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/localsend.json`:
- Line 11: Normalize the indentation in the localsend manifest using the
repository’s formatjson.ps1 formatter for the localsend app, ensuring the arm64
entry matches the surrounding space-based indentation; commit the resulting
formatted manifest.
---
Nitpick comments:
In `@bucket/localsend.json`:
- Around line 10-13: Validate the localsend manifest across both 64bit and arm64
architectures by forcing version detection, auto-formatting it, and running
clean-environment installation tests (or uninstalling between tests). Ensure the
committed bucket/localsend.json uses CRLF line endings and includes the
resulting validated formatting and metadata.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c4078cce-cdfc-4d49-950c-36c69f1cb41f
📒 Files selected for processing (1)
bucket/localsend.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. localsend
|
<manifest-name[@version]|chore>: <general summary of the pull request>