Skip to content

flclash: Patch for recovering app built-in manifest.json - #18530

Closed
AkariiinMKII wants to merge 1 commit into
ScoopInstaller:masterfrom
AkariiinMKII:fix-flclash
Closed

flclash: Patch for recovering app built-in manifest.json#18530
AkariiinMKII wants to merge 1 commit into
ScoopInstaller:masterfrom
AkariiinMKII:fix-flclash

Conversation

@AkariiinMKII

Copy link
Copy Markdown
Contributor

To solve the bug caused by file conflictions, this PR adds a backup script for conflicted file and prints notes for users to act

Closes #18529

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 206090e9-c154-4fdc-bd15-828e48f06f51

📥 Commits

Reviewing files that changed from the base of the PR and between da8fbe6 and 7d51c4e.

📒 Files selected for processing (1)
  • bucket/flclash.json

📝 Walkthrough

Walkthrough

The flclash manifest now includes a post_install script. The script renames manifest.json to manifest.flclash.json and prints TUN mode recovery instructions. The instructions include commands to restore the original manifest names.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: 🔵 Low · up to 7d51c

The change adds automatic backup and recovery guidance for a conflicting manifest file. It is mergeable with explicit owner follow-up to verify the full install and recovery flow, including manifest contents and supported architectures.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the flclash manifest recovery change and follows the repository’s conventional title format.
Description check ✅ Passed The description explains the file conflict fix, links the relevant issue, and confirms both required checklist items.
Linked Issues check ✅ Passed The change addresses issue #18529 by backing up the conflicting manifest and providing instructions to restore it for TUN mode.
Out of Scope Changes check ✅ Passed The seven added lines are limited to the manifest recovery script and related user instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AkariiinMKII

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

flclash

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Comment thread bucket/flclash.json
@z-Fng

z-Fng commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Would extracting to a subfolder to avoid overwriting manifest.json be a better approach? This wouldn't break other features.

Looks like someone else has already implemented the method I proposed (#18531).

Thank you for your contribution! Closing this PR as it is superseded by #18531.

@z-Fng z-Fng closed this Aug 14, 2026
@AkariiinMKII
AkariiinMKII deleted the fix-flclash branch August 14, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: flclash TUN Mode not work in latest version

2 participants