Skip to content

raspberry-pi-imager: Fix registry path - #18545

Closed
brian6932 wants to merge 1 commit into
ScoopInstaller:masterfrom
brian6932:raspberry-pi-imager/fix-registry-path
Closed

raspberry-pi-imager: Fix registry path#18545
brian6932 wants to merge 1 commit into
ScoopInstaller:masterfrom
brian6932:raspberry-pi-imager/fix-registry-path

Conversation

@brian6932

Copy link
Copy Markdown
Contributor

I'm unsure of whether or not I made a mistake when I wrote this in the past, or if the actual registry path changed.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 36ff061b-f466-415f-ac35-851607509f25

📥 Commits

Reviewing files that changed from the base of the PR and between 71d71df and 61f0768.

📒 Files selected for processing (1)
  • bucket/raspberry-pi-imager.json

Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Scoop manifest updates the Windows telemetry opt-out registry path from HKCU:/Software/Raspberry Pi/Raspberry Pi Imager to HKCU:/Software/Raspberry Pi/Imager.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to 61f07

The change updates the Windows registry path used for the telemetry opt-out command. If the path does not match the application’s settings key, the opt-out may not take effect; merge is reasonable with explicit owner confirmation of the packaged release’s registry contract.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and confirms both checklist items, but it does not include the required related issue reference. Add a relevant Package Request or Bug Report reference using a "Closes #XXXX" or "Relates to #XXXX" entry.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the manifest and the registry path fix, and it follows the required conventional format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brian6932

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

raspberry-pi-imager

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng

z-Fng commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

I'm unsure of whether or not I made a mistake when I wrote this in the past, or if the actual registry path changed.

Due to an upstream ApplicationName change (raspberrypi/rpi-imager@3b4052a), the 2.x registry path differs from 1.x. #16988 specifically fixed this. The existing registry path is already correct.

image

@z-Fng z-Fng added invalid This doesn't seem right. and removed review-needed labels Aug 18, 2026
@z-Fng z-Fng closed this Aug 18, 2026
@brian6932

brian6932 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Ah alright, didn't know it was changed, should've ran a blame first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants