-
Notifications
You must be signed in to change notification settings - Fork 106
Create graalvm25.json #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new JSON manifest file for GraalVM Community edition 25.0.1 (Windows x64) is introduced, defining package metadata, pre-install configuration steps, environment variable integration (JAVA_HOME, GRAALVM_HOME), and automated version update mechanism via GitHub repository monitoring. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with graalvm25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/graalvm25.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/graalvm25.json
[error] 1-1: GraalVM25 Checkver failed. WebClient request error: URL graalvm/graalvm-ce-builds/releases/latest is not valid.
[error] 1-1: Process completed with exit code 1.
🔇 Additional comments (2)
bucket/graalvm25.json (2)
20-25: Verify that the hash autoupdate URL is valid.The autoupdate configuration attempts to fetch the SHA256 hash from
$url.sha256(constructed by appending.sha256to the release download URL). Please confirm that GraalVM's GitHub releases include a.sha256file at this location, or adjust the hash fetch strategy if needed.
5-5: Correct the license identifier.GraalVM Community Edition uses the GraalVM Free Terms and Conditions License (GFTCL), not GPL-2.0. This metadata is user-facing and should reflect the actual license.
Apply this diff to correct the license:
- "license": "GPL-2.0", + "license": "GFTCL",Likely an incorrect or invalid review comment.
| "checkver": { | ||
| "github": "graalvm/graalvm-ce-builds" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix checkver configuration—pipeline is failing due to invalid URL construction.
The checkver configuration is incomplete and causing the pipeline to fail. The error indicates the constructed URL graalvm/graalvm-ce-builds/releases/latest is malformed. GraalVM releases use tags like jdk-25.0.1, so you need to specify a regex pattern to extract the version from the release tag.
Apply this diff to fix the checkver configuration:
"checkver": {
- "github": "graalvm/graalvm-ce-builds"
+ "github": "graalvm/graalvm-ce-builds",
+ "regex": "jdk-([\\d.]+)"
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "checkver": { | |
| "github": "graalvm/graalvm-ce-builds" | |
| }, | |
| "checkver": { | |
| "github": "graalvm/graalvm-ce-builds", | |
| "regex": "jdk-([\\d.]+)" | |
| }, |
🤖 Prompt for AI Agents
In bucket/graalvm25.json around lines 17-19, the checkver block only specifies
"github" and causes a malformed URL; update the checkver configuration to
include a regex that extracts the version from release tags (which are like
"jdk-25.0.1") so the pipeline builds a correct URL — add a "regex" value that
matches tags starting with "jdk-" and captures the numeric version portion (e.g.
jdk-<version>) and ensure checkver uses release tags for version extraction.
Closes #XXXX
Relates to #XXXX
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.