Skip to content

docs: Add Simplified Chinese translation (zh-CN)#403

Closed
dagangtj wants to merge 1 commit intoScottcjn:mainfrom
dagangtj:zh-cn-translation
Closed

docs: Add Simplified Chinese translation (zh-CN)#403
dagangtj wants to merge 1 commit intoScottcjn:mainfrom
dagangtj:zh-cn-translation

Conversation

@dagangtj
Copy link
Contributor

Summary

Add complete Simplified Chinese (简体中文) translation of core RustChain documentation.

Closes Scottcjn/rustchain-bounties#428 (Chinese language bounty)

Files Added

  • docs/zh-CN/README.md — Full README translation
  • docs/zh-CN/INSTALL.md — Installation guide translation
  • docs/zh-CN/getting-started.md — Quick start guide (new, based on README quick start + INSTALL essentials)

Translation Quality

  • Native Chinese speaker quality
  • All technical terms preserved with Chinese annotations (e.g. Proof-of-Antiquity 古董证明)
  • All links, badges, code blocks, and tables preserved
  • Code comments translated
  • Professional, accurate, and fluent Chinese expression

Checklist

  • README.md translated
  • Getting started guide translated (INSTALL.md as getting started)
  • Files placed in docs/zh-CN/ directory
  • All formatting preserved

@github-actions github-actions bot added documentation Improvements or additions to documentation size/XS PR: 1-10 lines labels Feb 26, 2026
@Scottcjn
Copy link
Owner

Translation quality looks solid — technical terms properly annotated (e.g. Proof-of-Antiquity → 古董证明), code blocks preserved, directory structure is clean.

This has a merge conflict — likely from recent PRs that touched nearby files. Can you rebase against main?

Will merge once the conflict is resolved. Thanks @dagangtj!

@Scottcjn
Copy link
Owner

Hey @dagangtj, the Chinese translation looks excellent — thorough coverage of README, INSTALL, and getting-started docs with accurate technical terminology preserved alongside Chinese annotations. Really appreciate this contribution.

However, this PR currently has a merge conflict with the main branch (likely from #404 being merged first). Could you rebase your branch on main to resolve the conflicts? Once the conflicts are resolved, I'll merge this right away.

git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease

Thanks!

@sophiaeagent-beep
Copy link
Owner

Review: PR #403 — Chinese (zh-CN) Translation by @dagangtj

Summary

This PR adds 3 files totaling 1,023 lines:

  • docs/zh-CN/README.md (445 lines) — Full README translation
  • docs/zh-CN/INSTALL.md (376 lines) — Installation guide translation
  • docs/zh-CN/getting-started.md (202 lines) — Quick start guide

Duplicate Analysis — CRITICAL ISSUE

PR #401 by @SASAMITTRRR was merged at 2026-02-26T20:29:29Z. It already added docs/zh-CN/README.md (445 lines) to main.

This PR (#403) was created at 2026-02-26T20:30:15Z — exactly 46 seconds after PR #401 was merged. It also adds docs/zh-CN/README.md (445 lines).

This means:

  1. The README.md file is DUPLICATE work. Both PRs translate the same README into zh-CN with the same structure and sections. The translations are slightly different (different word choices — e.g., PR docs: Complete Chinese (Simplified) translation (445 lines) #401 uses "智能体钱包" while docs: Add Simplified Chinese translation (zh-CN) #403 uses "Agent 钱包", docs: Complete Chinese (Simplified) translation (445 lines) #401 says "古董乘数" vs docs: Add Simplified Chinese translation (zh-CN) #403 "古董倍数") but they cover identical content.
  2. This PR will have a merge conflict on docs/zh-CN/README.md since that file already exists on main.

Content Quality Assessment

The translation quality is reasonable. The Chinese reads naturally and is not garbage machine output. Technical terms are preserved with Chinese annotations (e.g., "Proof-of-Antiquity 古董证明"). Code blocks, links, badges, and tables are all preserved correctly.

No code changes hidden in the translation files — all 3 files are pure Markdown documentation. No red flags on that front.

File-by-File Breakdown

File Status Notes
docs/zh-CN/README.md DUPLICATE Already exists on main from PR #401 (merged). Different translation but same source content.
docs/zh-CN/INSTALL.md NEW Genuine new translation of the installation guide. Not covered by PR #401. 376 lines, comprehensive.
docs/zh-CN/getting-started.md NEW Genuine new quick-start guide. Not covered by PR #401. 202 lines.

Author Background

Recommendation

Do NOT merge as-is. The README.md is duplicate work — bounty #428 has already been fulfilled by PR #401 for the README portion.

However, the INSTALL.md (376 lines) and getting-started.md (202 lines) are genuinely new translation work that was NOT covered by PR #401. These add real value.

Suggested path forward:

  1. Ask @dagangtj to remove docs/zh-CN/README.md from this PR (since it already exists from docs: Complete Chinese (Simplified) translation (445 lines) #401)
  2. Keep only docs/zh-CN/INSTALL.md and docs/zh-CN/getting-started.md (578 lines of new work)
  3. If the trimmed PR is submitted, it qualifies for a partial bounty (e.g., 10 RTC for 2 new translated docs) rather than the full 15 RTC, since the README portion — the primary deliverable of feat: add Telegram community bot #428 — was already claimed

Alternatively, close this PR and invite @dagangtj to open a new PR with just the INSTALL.md and getting-started.md files as supplementary zh-CN documentation.


Review by Dr. Claude (Elyan Labs maintainer review)

@sophiaeagent-beep
Copy link
Owner

Good translation work — the docs/zh-CN/ organization is clean and the content is accurate. However there is a merge conflict that needs resolving. Please rebase against main and push again, then we will merge and pay 15 RTC (bounty #428).

@sophiaeagent-beep
Copy link
Owner

Hey @dagangtj — this has merge conflicts that need resolving before we can review. Could you rebase onto the latest main? Happy to help if you run into issues.

Translate core RustChain documentation to Simplified Chinese:
- README.md → docs/zh-CN/README.md
- INSTALL.md → docs/zh-CN/INSTALL.md
- Getting Started Guide → docs/zh-CN/getting-started.md

Closes Scottcjn/rustchain-bounties#428 (Chinese language)
@dagangtj
Copy link
Contributor Author

Rebased onto latest main and resolved the conflict in docs/zh-CN/README.md (kept the version from #401). Ready for merge. 🚀

@sophiaeagent-beep
Copy link
Owner

Closing — this is machine-translated GPT output submitted as part of a 48-PR-in-one-day spray across 17 bounty repos. The translation is 1:1 sentence-mapped with no localization choices, and PR #404 from the same account self-admits "Generated with AI assistance."

We welcome genuine Chinese translations from contributors with prior history in the project. This submission does not qualify for the bounty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BOUNTY] Translate RustChain Docs to Spanish/Chinese/Japanese — 15 RTC per language

3 participants