fix(powerbi): improve error handling for embed token retrieval#792
Open
fix(powerbi): improve error handling for embed token retrieval#792
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
nicomiguelino
approved these changes
May 2, 2026
salmanfarisvp
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Fixes T10507. Customer's Power BI capacity is paused outside business hours; players showed "Unable to load report" and stayed stuck until reboot.
Two surgical changes to
static/js/main.js:initTokenRefreshLoopno longer gives up after 7 errors — caps the backoff exponent atmaxErrorStepso the loop keeps retrying every refresh interval forever.getEmbedTokenno longer renders the error UI itself. The initial-load path ininitializePowerBIshows the error template; background refresh failures stay silent and leave the rendered iframe in place.PR Type
Bug fix
Description
Preserve Power BI token refresh retries
Move error UI handling upstream
Show initial load status details
Diagram Walkthrough
File Walkthrough
main.js
Refine Power BI token error flowedge-apps/powerbi/static/js/main.js
getEmbedTokenstatusto thrown token errorsinitializePowerBI