feat: Add support for epoch_millis and epoch_second time formats#71
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Elasticsearch range query DSL handling in quickwit-query to properly support format: "epoch_millis" and format: "epoch_second" by converting epoch bounds into RFC3339 strings before building the RangeQuery AST.
Changes:
- Add explicit handling for
epoch_millisandepoch_secondformats in range queries. - Introduce an epoch conversion helper that accepts numeric and numeric-string bounds and formats them as RFC3339.
- Add unit tests covering both epoch formats.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rdettai-sk
approved these changes
Jun 25, 2026
rdettai-sk
requested changes
Jun 25, 2026
rdettai-sk
left a comment
rdettai-sk
left a comment
Collaborator
There was a problem hiding this comment.
actually, the right fix would be to forward the timestamp as is when format = epoch_xxx
Darkheir
force-pushed
the
feat/epoch_time_format
branch
2 times, most recently
from
baaf486 to
62d4507
Compare
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/epoch_time_format
branch
from
62d4507 to
19d36e7
Compare
Collaborator
Author
Done |
rdettai-sk
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.