feat: Refine timestamp from search after#72
Open
Darkheir wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the effective start_timestamp/end_timestamp bounds used during split selection by additionally tightening them from the search_after cursor when the primary sort field is the timestamp field, aiming to improve pruning for paginated searches.
Changes:
- Import
SortOrderand addrefine_timestamps_from_search_afterto derive tighter timestamp bounds fromsearch_after. - Invoke the refinement during
refine_and_list_matchesafter AST-based timestamp extraction and after datetime cursor normalization. - Add unit tests covering DESC/ASC behavior and no-op scenarios.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Darkheir
force-pushed
the
feat/refine_timestamp_search_after
branch
from
7fb4fa5 to
a703f12
Compare
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/refine_timestamp_search_after
branch
from
a703f12 to
3a37992
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.