[Form] Fixes "remove rule(field)" throw exception if field has no rules#6940
Open
jameschenjav wants to merge 1 commit intoSemantic-Org:masterfrom
jameschenjav:fix_form_validation_undefined_rules
Open
[Form] Fixes "remove rule(field)" throw exception if field has no rules#6940jameschenjav wants to merge 1 commit intoSemantic-Org:masterfrom jameschenjav:fix_form_validation_undefined_rules
jameschenjav wants to merge 1 commit intoSemantic-Org:masterfrom
jameschenjav:fix_form_validation_undefined_rules
Conversation
visit `rules` on undefined `validation[field]`
This comment was marked as spam.
This comment was marked as spam.
Author
|
hi @lubber-de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed Issues
#5745
Description
remove rule(field, rules)should remove all rules when argumentrulesis omitted. Butfieldmay not have any rules, and it would raise exceptions because ofvalidation[field].rules = [].There is some guard code to check if
validation[field].rulesexists, but the order is wrong apparently.Testcase
https://jsfiddle.net/whd3o60j/3/
Click "Remove All Validations", raised exception
Uncaught TypeError: Cannot set property 'rules' of undefined(in Chrome)