-
Notifications
You must be signed in to change notification settings - Fork 150
Day 0 GB300 DeepSeek-V4-Pro FP4 vLLM disagg #1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oseltamivir
wants to merge
29
commits into
main
Choose a base branch
from
dsv4-fp4-gb300-dynamo-vllm-disagg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
154be8d
Port DeepSeek-V4-Pro FP4 disaggregated vLLM sweep from gb200 to gb300-cr
Oseltamivir 017b66a
Fill in PR link for gb300-cr changelog entry
Oseltamivir b91ca49
Rename gb300-cr to gb300-cw; fix model path to /mnt/vast/models/dsv4/
Oseltamivir b6ebbd3
Fix gb300-cw SLURM account and extend runner group to _2/_3
Oseltamivir c6b45fd
Pin runner-side uv to /tmp so x86 binary doesn't leak to ARM64 compute
Oseltamivir aaea407
Force --segment per recipe via sbatch_directives
Oseltamivir 3bd82f1
Cap cargo parallelism via CARGO_BUILD_JOBS=4 in gb300 recipes
Oseltamivir b3d2b12
Force --mem=0 (use full node memory) on every gb300 recipe; fix hered…
Oseltamivir b3d2bd8
Merge branch 'main' into dsv4-fp4-gb300-dynamo-vllm-disagg
Oseltamivir 33f6eb4
Update perf-changelog.yaml
Oseltamivir 43c3bc4
Update gb300 recipe headers — segment is recipe-driven, not auto
Oseltamivir 32aca3e
Set NVIDIA_VISIBLE_DEVICES + DRIVER_CAPABILITIES so enroot mounts lib…
Oseltamivir e66e667
Cache dynamo wheel build globally on /mnt/vast (gb300-cw)
Oseltamivir 9cb8ee5
Switch dynamo cache lock from flock to mkdir (NFS doesn't honor flock)
Oseltamivir 369b1ed
Pre-build dynamo wheel via single-node srun before sbatch (gb300-cw)
Oseltamivir f37eb70
Prebuild srun: add --mem=0, cap CARGO_BUILD_JOBS=8, drop rustc debuginfo
Oseltamivir 86ac394
Mount /mnt/vast/dynamo_cache into worker containers (extra_mount)
Oseltamivir 6997f95
Patch vllm HANDSHAKE_TIMEOUT_MINS 5->30 in setup script
Oseltamivir 3900434
Drop NVL-only NCCL flags + add NCCL_DEBUG=INFO
Oseltamivir 7851967
Re-add NCCL_MNNVL_ENABLE, add debug diagnostics, reduce to 1p1d repro…
Oseltamivir 87bdf1f
Remove vLLM HANDSHAKE_TIMEOUT_MINS sed patch from setup script
Oseltamivir 7f526db
Restore handshake timeout patch, add DP Coordinator logging, drop NCC…
Oseltamivir 6415458
Rewrite coordinator patch to match actual vLLM source strings
Oseltamivir cedac56
Rewrite coordinator patch: regex matching + inspect.getsource verify
Oseltamivir ff4ab3a
Merge branch 'main' into dsv4-fp4-gb300-dynamo-vllm-disagg
Oseltamivir 8570717
more
Oseltamivir b39f41e
Merge branch 'main' into dsv4-fp4-gb300-dynamo-vllm-disagg
Oseltamivir 3f33f27
Merge branch 'main' into dsv4-fp4-gb300-dynamo-vllm-disagg
Oseltamivir df79838
configs
Oseltamivir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
...arks/multi_node/srt-slurm-recipes/vllm/deepseek-v4/1k1k/disagg-gb300-1p1d-dep8-dep16.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| name: "dsv4-vllm-disagg-gb300-1p1d-dep8-dep16" | ||
|
|
||
| # GB300 mirror of disagg-gb200-1p1d-dep8-dep16.yaml. Same tuning at FP4 | ||
| # (288 GB HBM/GPU on GB300 vs 184 GB on GB200 — extra headroom for KV). | ||
| # Cluster: gb300-cw (2x 18-node racks); job pins to one rack via the | ||
| # explicit sbatch_directives.segment="6" below (cw's srtslurm.yaml turns | ||
| # off srtctl's auto-segment so each recipe owns its segment value). | ||
| # | ||
| # 1k/1k mid-to-high throughput topology. Single prefill worker feeding a | ||
| # wide DP=16 decode handles conc 256-4096 cleanly for 1k prompts. | ||
|
|
||
| model: | ||
| path: "deepseek-v4-pro" | ||
| container: "vllm/vllm-openai:deepseekv4-cu130" | ||
| precision: "fp4" | ||
|
|
||
| dynamo: | ||
| hash: 6a159fedd8e4a1563aa647c31f622aedbf254b5b | ||
| # Install handled by our custom vllm-container-deps.sh, which builds | ||
| # the dynamo wheel ONCE on /mnt/vast and lets every rank pip-install | ||
| # from cache. See runners/gb300-cw-vllm-container-deps.sh. | ||
| install: false | ||
|
|
||
| setup_script: vllm-container-deps.sh | ||
|
|
||
| # Mount /mnt/vast/dynamo_cache into every worker container so each | ||
| # rank can pip-install from the wheel that launch_gb300-cw.sh | ||
| # pre-built there. Without this only /mnt/vast/models/<model> is | ||
| # in scope and our setup script errors out with 'prebuilt cache | ||
| # missing'. | ||
| extra_mount: | ||
| - "/mnt/vast/dynamo_cache:/mnt/vast/dynamo_cache" | ||
|
|
||
| # Pin all 6 nodes to the same rack on cw. | ||
| sbatch_directives: | ||
| segment: "6" | ||
| # Use all node memory; cw default was too tight. | ||
| mem: "0" | ||
|
|
||
| slurm: | ||
| time_limit: "8:00:00" | ||
|
|
||
| health_check: | ||
| max_attempts: 1440 | ||
| interval_seconds: 10 | ||
|
|
||
| resources: | ||
| gpu_type: "gb300" | ||
| gpus_per_node: 4 | ||
| prefill_nodes: 2 | ||
| decode_nodes: 4 | ||
| prefill_workers: 1 | ||
| decode_workers: 1 | ||
| gpus_per_prefill: 8 | ||
| gpus_per_decode: 16 | ||
|
|
||
| frontend: | ||
| type: dynamo | ||
| enable_multiple_frontends: false | ||
|
|
||
| backend: | ||
| type: vllm | ||
| connector: null | ||
|
|
||
| prefill_environment: | ||
| VLLM_ENGINE_READY_TIMEOUT_S: "3600" | ||
| TILELANG_CLEANUP_TEMP_FILES: "1" | ||
| CARGO_BUILD_JOBS: "4" | ||
| VLLM_USE_NCCL_SYMM_MEM: "1" | ||
| NCCL_CUMEM_ENABLE: "1" | ||
| NCCL_MNNVL_ENABLE: "1" | ||
| NCCL_NVLS_ENABLE: "1" | ||
| NCCL_DEBUG: "INFO" | ||
| NCCL_DEBUG_SUBSYS: "INIT,BOOTSTRAP,ENV,NET,GRAPH,NVLS" | ||
| VLLM_SERVER_DEV_MODE: "1" | ||
|
|
||
| decode_environment: | ||
| VLLM_ENGINE_READY_TIMEOUT_S: "3600" | ||
| TILELANG_CLEANUP_TEMP_FILES: "1" | ||
| CARGO_BUILD_JOBS: "4" | ||
| VLLM_USE_NCCL_SYMM_MEM: "1" | ||
| NCCL_CUMEM_ENABLE: "1" | ||
| NCCL_MNNVL_ENABLE: "1" | ||
| NCCL_NVLS_ENABLE: "1" | ||
| NCCL_DEBUG: "INFO" | ||
| NCCL_DEBUG_SUBSYS: "INIT,BOOTSTRAP,ENV,NET,GRAPH,NVLS" | ||
| VLLM_SERVER_DEV_MODE: "1" | ||
|
|
||
| vllm_config: | ||
| prefill: | ||
| kv-transfer-config: '{"kv_connector": "NixlConnector", "kv_role": "kv_both"}' | ||
| served-model-name: "deepseek-ai/DeepSeek-V4-Pro" | ||
| kv-cache-dtype: "fp8" | ||
| tensor-parallel-size: 1 | ||
| pipeline-parallel-size: 1 | ||
| data-parallel-size: 8 | ||
| data-parallel-rpc-port: 13345 | ||
| enable-expert-parallel: true | ||
| enforce-eager: true | ||
| max-model-len: 3072 | ||
| max-num-seqs: 16 | ||
| max-num-batched-tokens: 16384 | ||
| trust-remote-code: true | ||
| no-enable-prefix-caching: true | ||
| no-enable-flashinfer-autotune: true | ||
| block-size: 256 | ||
| gpu-memory-utilization: 0.88 | ||
| no-disable-hybrid-kv-cache-manager: true | ||
| enable-sleep-mode: true | ||
|
|
||
| decode: | ||
| kv-transfer-config: '{"kv_connector": "NixlConnector", "kv_role": "kv_both"}' | ||
| served-model-name: "deepseek-ai/DeepSeek-V4-Pro" | ||
| kv-cache-dtype: "fp8" | ||
| tensor-parallel-size: 1 | ||
| pipeline-parallel-size: 1 | ||
| data-parallel-size: 16 | ||
| data-parallel-rpc-port: 13345 | ||
| enable-expert-parallel: true | ||
| max-model-len: 3072 | ||
| max-num-seqs: 512 | ||
| max-cudagraph-capture-size: 512 | ||
| max-num-batched-tokens: 512 | ||
| trust-remote-code: true | ||
| no-enable-prefix-caching: true | ||
| block-size: 256 | ||
| compilation-config: '{"cudagraph_mode":"FULL_DECODE_ONLY","mode":0}' | ||
| gpu-memory-utilization: 0.9 | ||
| stream-interval: 50 | ||
| no-disable-hybrid-kv-cache-manager: true | ||
| enable-sleep-mode: true | ||
|
|
||
| benchmark: | ||
| type: "sa-bench" | ||
| isl: 1024 | ||
| osl: 1024 | ||
| concurrencies: "128x256x1024x2048x4096" | ||
| req_rate: "inf" | ||
| use_chat_template: false |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Comment at line 7666 reads "Same topology + tuning as dsv4-fp4-gb300-dynamo-vllm's gb200 sibling" but it's inside the dsv4-fp4-gb300-dynamo-vllm config block (declared at line 7657) — so the config is referring to itself as having a gb200 sibling. Almost certainly a copy-paste leftover from the GB200→GB300 port; should reference
dsv4-fp4-gb200-dynamo-vllminstead. Pure comment-only nit, no runtime effect.Extended reasoning...
What's wrong
In .github/configs/nvidia-master.yaml the new config block
dsv4-fp4-gb300-dynamo-vllm:is declared at line 7657. The header comment for that block, lines 7666-7668, currently reads:A config can't be its own sibling. The author clearly intended to point at
dsv4-fp4-gb200-dynamo-vllm— that is the existing GB200 config defined immediately above (ending at line 7655) and the actual upstream this PR ports from.Step-by-step proof
dsv4-fp4-gb300-dynamo-vllm:— this opens the config block.Impact
None on runtime, parsing, generated artifacts, or sweep behavior — YAML comments are inert. This is purely a readability issue: a future reader following the comment will go looking for a non-existent reference.
Fix
Change
dsv4-fp4-gb300-dynamo-vllm's gb200 siblingtodsv4-fp4-gb200-dynamo-vllm(or equivalent phrasing such as "as the gb200 sibling (dsv4-fp4-gb200-dynamo-vllm)"). One-token edit while the PR is still open.