perf(gb300): add AgentX aggregate TP4 points / 添加 GB300 AgentX 聚合式 TP4 数据点 - #2676
perf(gb300): add AgentX aggregate TP4 points / 添加 GB300 AgentX 聚合式 TP4 数据点#2676ivanium wants to merge 1 commit into
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
为 GB300 AgentX 聚合式 TP4 扫描新增并发 1、2、4 和 6,同时保留现有并发 8 数据点。
64beebf to
e9bee35
Compare
|
Claude finished @ivanium's task in 2m 4s —— View job PR Review
LGTM - no blocking issues found Verification details:
Note: I could not execute the exact-key generation script in this sandbox (Python execution requires approval), so the base⊆head check was done by inspecting the diff rather than by re-running the generator. Since the change is a pure |
There was a problem hiding this comment.
LGTM — straightforward sweep expansion, no bugs found.
What was reviewed: the diff only widens conc-list from [8] to [1, 2, 4, 6, 8] on the existing GB300 AgentX aggregate TP4 recipe entry, with the referenced recipe file (agg-gb300-tp4-mtp-agentic.yaml) left untouched, plus a matching append-only changelog entry. Confirmed the TP4 block sits alongside the untouched TP8 block in nvidia-master.yaml and that no other config or launcher logic was touched.
Extended reasoning...
Overview
This PR touches only configs/nvidia-master.yaml and perf-changelog.yaml. It expands the conc-list for the existing dsv4-fp4-gb300-dynamo-vllm-agentic-mtp-agg TP4 scenario entry from [8] to [1, 2, 4, 6, 8], and appends a corresponding changelog entry describing the change with an append-only: true marker. No recipe files, launcher code, or scoring logic were modified.
Security risks
None. This is a pure data change to a benchmark sweep configuration — no new code paths, no external inputs, no auth/crypto/permission surfaces touched.
Level of scrutiny
Low. This is a mechanical, additive change to an existing, already-validated recipe (same image, same CONFIG_FILE, same TP/EP/dp-attn settings) — only the concurrency sweep points are widened. The changelog entry is consistent with the diff and marked append-only, matching repository convention for this file.
Other factors
The bug-hunting system found no issues, and the one candidate concern raised (a stale 'concurrency 8' comment in the referenced TP4 recipe) was investigated and ruled out. The PR description states 36 focused tests passed for exact-key generation and append-only validation. No unresolved reviewer comments exist in the timeline.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=32242794988 |
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=32242794988 |
Summary / 摘要
Validation / 验证
Exact-key generation and append-only validation passed; 36 focused tests passed. / 精确配置生成和仅追加校验通过;36 项专项测试通过。