Skip to content

Remove the deprecated positional send_command() overload #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kahrendt merged 1 commit into from
Sep 15, 2026
Merged

Remove the deprecated positional send_command() overload #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/integration-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,6 @@ controller.send_command({.command = SendspinControllerCommand::SEEK_RELATIVE, .o

Fields that do not match the command are ignored when the message is serialized. The server clamps seeks to the seekable range and ignores any command not present in the controller state's `supported_commands`.

> **Deprecated:** the earlier positional overload `send_command(cmd, volume, mute)` still works but cannot carry seek parameters and will be removed in v0.8.0. Migrate to the struct form above.

## Accessing Roles

In addition to the references returned by `add_*()`, you can access roles at any time through the client's accessor methods. These return `nullptr` if the role was not added.
Expand Down
9 changes: 0 additions & 9 deletions include/sendspin/controller_role.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,6 @@ class ControllerRole {
/// @param cmd The command plus any command-specific parameters
void send_command(const ClientCommandControllerObject& cmd);

/// @brief Sends a controller command to the server
/// @deprecated Use send_command(const ClientCommandControllerObject&) instead. This overload
/// cannot carry seek parameters and will be removed in v0.8.0.
[[deprecated(
"use send_command(const ClientCommandControllerObject&); this overload cannot carry seek "
"parameters and will be removed in v0.8.0")]]
void send_command(SendspinControllerCommand cmd, std::optional<uint8_t> volume = {},
std::optional<bool> mute = {});

private:
std::unique_ptr<Impl> impl_;
};
Expand Down
5 changes: 0 additions & 5 deletions src/controller_role.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ void ControllerRole::send_command(const ClientCommandControllerObject& cmd) {
this->impl_->send_command(cmd);
}

void ControllerRole::send_command(SendspinControllerCommand cmd, std::optional<uint8_t> volume,
std::optional<bool> mute) {
this->impl_->send_command({.command = cmd, .volume = volume, .muted = mute});
}

// ============================================================================
// Impl method implementations
// ============================================================================
Expand Down
Loading