Fix various foil inaccuracies in BoosterFactory#993
Open
hbkse wants to merge 3 commits into
Open
Conversation
Both comments give a 20% traditional foil rate for the land slot (TDM: 1.7% + 0.9% + 17.4% foil out of ~100%; TMT: 12% + 8% out of 100%), but TDM rolled foil at 40% and TMT at 25%. Other factories with the same 20% rate (TLA, SOS, MSH) already use 1/5. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- DFT land slot: the collecting article says the land is traditional foil in 20% of boosters, but no foil was ever rolled. - OM1: the traditional foil slot pushed a non-foil card, and the land slot ignored its documented 20% foil chance. - DBL: the silver screen foil card was pushed without the foil flag. - MB2: the 1% traditional foil acorn Alchemy card was pushed non-foil.
- TMT: the scene and sewer uncommon replacements shared one roll but used two independent if statements, so any roll under 3.9% fired both branches, replacing two uncommons at once and inflating the sewer rate to ~11.7% instead of 7.8%. The code's own comment says they should not appear together. - SPM/OM1: SpiderWebBasics covers collector numbers 189-193 and Basics started at 193, so the spiderweb Forest (Senryoku#193) appeared in both pools, doubling its pull rate. Basics now covers 194-198, the default frame cycle.
Owner
|
First 3 commits look good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.