Repository navigation
fix: refresh @modelcontextprotocol/sdk for GHSA-6qxp-vccf-f47h - #27
Merged
Merged
Conversation
npm audit now reports a high-severity advisory for @modelcontextprotocol/sdk 1.12.0–1.30.1: the OAuth client could send credentials to an authorization server chosen by the MCP server. CI's production-dependency audit therefore fails on every run, main included. Pin the lockfile to 1.31.0, the first patched release; package.json's ^1.30.0 range is unchanged. Upstream, 1.30.1 and 1.31.0 change only the OAuth client and the HTTP transport's body limits. SAB uses only the stdio Server, so the vulnerable path was never loaded. Validated: - npm audit reports 0 vulnerabilities, npm test passes (564), and npm run check passes. - An end-to-end smoke test ran the real channel/server.mjs on 1.31.0 against a local fake daemon. It covered the MCP handshake with both claude/channel capabilities, an SSE message delivered as notifications/claude/channel, and a permission request relayed to the daemon. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Xs8AVBVrTGfpzUMiCQp2R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm audit --omit=devnow fails CI on every run,mainincluded, because of a newly published high-severity advisory: GHSA-6qxp-vccf-f47h. In@modelcontextprotocol/sdk1.12.0–1.30.1, the OAuth client could send credentials to an authorization server chosen by the MCP server.This lockfile-only change pins the SDK to 1.31.0, the first patched release. The
package.jsonrange^1.30.0is unchanged, so this works like #25.Runtime exposure: none. SAB uses only the SDK's stdio
Server(channel/server.mjs), never the OAuth client. The upstream changes in 1.30.1 and 1.31.0 touch only the OAuth client and the HTTP transport's body limits. The fix is needed to unblock CI for #26.Validation
npm audit --omit=dev: 0 vulnerabilities.npm test: 564 pass.npm run check: pass.channel/server.mjswith only its daemon address redirected to a local fake daemon, driven by an MCP client:claude/channelandclaude/channel/permission;notifications/claude/channel;permission_requestnotification is relayed to/permission-request.Deployment notes
package.jsonchanges. Installs therefore keep 1.30.0 on disk until they runnpm ci --omit=dev.🤖 Generated with Claude Code
https://claude.ai/code/session_011Xs8AVBVrTGfpzUMiCQp2R