Fix triton cross-entropy for large vocab sizes, support tensor-parallel#466
Open
jlamypoirier wants to merge 11 commits intojlp_entropy_loss_tweaksfrom
Open
Fix triton cross-entropy for large vocab sizes, support tensor-parallel#466jlamypoirier wants to merge 11 commits intojlp_entropy_loss_tweaksfrom
jlamypoirier wants to merge 11 commits intojlp_entropy_loss_tweaksfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Greatly expand the triton implementation of loss kernels:
There shouldn't be any reason for using fused implementations anymore, and to facilitate the transition I removed the parameter altogether so existing configs switch to triton automatically. I added the
use_tritonparameter in case we do need to disable triton at some point.For a single loss, the implementation should be optimal WRT read/writes of logits and their gradients, which is the bottleneck for these losses. However, it's still sub-optimal with multiple losses because of redundant computations and sub-optimal gradient accumulation. Some of this could be addressed in a follow-up PR.
As an example, a here is a benchmark I ran for cross-entropy from labels (8K tokens, cuda time + est. memory usage):
Also found out about triton's interpreter mode, which allows testing triton kernels on CPU. I adjusted the triton tests to support it, so almost every test can now be run without GPU access (Only distributed and megatron model tests remain.) They still won't run on github though because installing triton would be a bit difficult.