Skip to content

Add ramp section - #186

Open
AwesomeTornado wants to merge 3 commits into
mainfrom
feature/ramp-inj
Open

Add ramp section#186
AwesomeTornado wants to merge 3 commits into
mainfrom
feature/ramp-inj

Conversation

@AwesomeTornado

Copy link
Copy Markdown
Member

@elsevers @noguchi-takahiro
Closes #49

Self-Review

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@AwesomeTornado AwesomeTornado self-assigned this Jul 28, 2026
@AwesomeTornado
AwesomeTornado requested a review from elsevers as a code owner July 28, 2026 19:47
@AwesomeTornado AwesomeTornado linked an issue Jul 28, 2026 that may be closed by this pull request

@noguchi-takahiro noguchi-takahiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AwesomeTornado, the updated article looks good.

I am noting one thing in Using Injection Commands section:

Image

The ramp command is missing here, only because we do not actually have that command in cmd_inj.c. I think we can merge this PR but we should make the issue in AMDC-Firmware repo to update help command to include the description about the ramp injection.

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

@elsevers could you review this PR? Here is the rendering version of the article: injection.pdf.

@elsevers

Copy link
Copy Markdown
Contributor

Thanks @noguchi-takahiro and @AwesomeTornado, can you go ahead and create the issue. Then let me know and I'll approve this.

@AwesomeTornado

Copy link
Copy Markdown
Member Author

@elsevers @noguchi-takahiro
I have updated the Using Injection Commands section, and created a new PR in the AMDC-Firmware repo.

This PR and the new one I created are both ready for re-review.

@elsevers elsevers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Looks great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new ramp section to injection page

3 participants