Add ramp section - #186
Conversation
noguchi-takahiro
left a comment
There was a problem hiding this comment.
Thank you @AwesomeTornado, the updated article looks good.
I am noting one thing in Using Injection Commands section:
The ramp command is missing here, only because we do not actually have that command in cmd_inj.c. I think we can merge this PR but we should make the issue in AMDC-Firmware repo to update help command to include the description about the ramp injection.
- Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
- Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
- Do all Markdown files follow the CONTRIBUTING article template? Yes
- Do all links work in the material that the PR is adding? Yes
- Is the PR configured to close the correct issue(s)? Yes
- Did the PR fully address the
Approachsection of the issue(s) it is closing? Yes
@elsevers could you review this PR? Here is the rendering version of the article: injection.pdf.
|
Thanks @noguchi-takahiro and @AwesomeTornado, can you go ahead and create the issue. Then let me know and I'll approve this. |
|
@elsevers @noguchi-takahiro This PR and the new one I created are both ready for re-review. |
elsevers
left a comment
There was a problem hiding this comment.
- Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
- Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
- Do all Markdown files follow the CONTRIBUTING article template? Yes
- Do all links work in the material that the PR is adding? Yes
- Is the PR configured to close the correct issue(s)? Yes
- Did the PR fully address the
Approachsection of the issue(s) it is closing? Yes
Looks great, thanks.
@elsevers @noguchi-takahiro
Closes #49
Self-Review
Approachsection of the issue(s) it is closing? YesReviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist