fix(Hardware Support): Fix Legion Go Regressions#610
Merged
Conversation
pastaq
force-pushed
the
pastaq/go_go2_split
branch
from
7b3a684 to
31569e6
Compare
ShadowApex
requested changes
Jun 20, 2026
ShadowApex
left a comment
ShadowApex
left a comment
Contributor
There was a problem hiding this comment.
A few comments, but otherwise looks good 👍
| //log::debug!(" ---- End Report ----"); | ||
|
|
||
| // Update the state | ||
| let old_dinput_state = self.update_xinput_state(input_report); |
Contributor
There was a problem hiding this comment.
Should this be old_xinput_state?
Fixes multiple regressions on the Legion Go 1 with original firmware by doing the following: - Split original Go 1 firmware and new Go 2 firmware into separate drivers. - Remove unsupported events (IMU events, M1, Alt-Tab, and Show Desktop buttons), from the Go 1 driver. - Remove default event filter from the Go 1 driver. - Remove Screen based IMU from the Go 2 configuration.
pastaq
force-pushed
the
pastaq/go_go2_split
branch
from
31569e6 to
773e4c4
Compare
ShadowApex
approved these changes
Jun 21, 2026
Contributor
|
🎉 This PR is included in version 0.77.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple regressions on the Legion Go 1 with original firmware by doing the following:
Fixes #597