Skip to content

fix: keep Learn IR visible when no remotes are configured - #24

Merged
sickkick merged 2 commits into
mainfrom
cursor/fix-learn-ir-menu-visibility-0f8a
Sep 21, 2026
Merged

sickkick merged 2 commits into
mainfrom
cursor/fix-learn-ir-menu-visibility-0f8a

Conversation

@sickkick

@sickkick sickkick commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Learn IR command (pinhole) disappeared from Configure whenever no remotes were set up. That became common after the infrared emitter work (v1.1.x): gateways often have emitters without button remotes, and on iTach there is no infrared receiver path for learning.

Changes

  • Always list Learn IR command (pinhole) in the Configure menu
  • When there are no remotes, the Learn IR step collects remote name + IR connector and creates the remote with the learned command
  • Hide Remove remote when the remotes list is empty (same gating as Edit remote)
  • Docs: README Learn IR subsection, CONTEXT menu/translation notes (options_menu, {ir_hint}, remote_name form key)
  • Folded in closed #23: CONTEXT production snapshot → v1.1.3 + release summary
  • Unit tests for menu visibility

Test plan

  • pytest tests/test_options_menu.py (+ non-HA suite) passes
  • On HA: Configure with no remotes → menu shows Learn IR
  • Learn IR with no remotes → create remote + capture still works
  • Learn IR with existing remotes → pick remote as before
Open in Web Open in Cursor 

@cursor
cursor Bot force-pushed the cursor/fix-learn-ir-menu-visibility-0f8a branch from 4dc64c6 to 4192a44 Compare September 21, 2026 14:51
After the infrared platform release, many setups have emitters without
remotes. Learn IR was hidden in that case, leaving iTach users with no
pinhole capture path. Always show the option and create a remote during
learn when none exist.

Docs: README Learn IR subsection, CONTEXT menu/translation notes.

Signed-off-by: Michael Shaffer <sickkick40@gmail.com>
@cursor
cursor Bot force-pushed the cursor/fix-learn-ir-menu-visibility-0f8a branch from 4192a44 to 6e56684 Compare September 21, 2026 14:52
@sickkick
sickkick marked this pull request as ready for review September 21, 2026 14:52
Fold in the curated release summary from the closed docs PR so the
handoff file matches the published GitHub release notes.

Signed-off-by: Michael Shaffer <sickkick40@gmail.com>
@sickkick
sickkick merged commit 791b5b8 into main Sep 21, 2026
2 checks passed
@sickkick
sickkick deleted the cursor/fix-learn-ir-menu-visibility-0f8a branch September 21, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant