Improved the Name Generator by moving the names and last names to the resources.#25
Open
AdriaanBoshoff wants to merge 5 commits intoShaunRoselt:masterfrom
Open
Improved the Name Generator by moving the names and last names to the resources.#25AdriaanBoshoff wants to merge 5 commits intoShaunRoselt:masterfrom
AdriaanBoshoff wants to merge 5 commits intoShaunRoselt:masterfrom
Conversation
Also note. I do not have the Linux platform installed so the IDE removed it. Just add it back when opening on your side.
ShaunRoselt
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names and last name files can be found in Resources\Tools\Roselt.NameGenerator. It's a lot quicker and easier to add new data. Just add them to the file and rebuild. Another thing is the build time changed from 1 minutes and 20 seconds to 3 seconds.