insert profiling middleware after Rack::Events #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmansoob
changed the title
bmansoob
force-pushed
the
middleware-order
branch
from
36c9485 to
acb52fe
Compare
dalehamel
reviewed
Feb 28, 2025
bmansoob
force-pushed
the
middleware-order
branch
from
acb52fe to
717d766
Compare
bmansoob
commented
Mar 3, 2025
| app.middleware.insert_before(0, AppProfiler.viewer::Middleware) | ||
| end | ||
| app.middleware.insert_before(0, AppProfiler.middleware) | ||
| if AppProfiler.otel_instrumentation_enabled |
Contributor
Author
There was a problem hiding this comment.
Otel gems use Rack::Events. So inserting the profiling middleware, after Rack::Events, based on the config value makes sense to me.
What do you think @gmcgibbon?
Member
There was a problem hiding this comment.
Does otel itself add them events middleware? A vanilla app doesn't have it. If so, this is ok.
Contributor
Author
There was a problem hiding this comment.
gmcgibbon
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
Rack::Eventsis usually one of the first middlewares in chain. For Core, it is the first.But for some apps it seems like it can appear after the profiling middleware. In that scenario, otel tracing attributes would not work.
Is this okay to do? @gmcgibbon