Skip to content

feat(RN): Include remaining public protocol events from native#186

Open
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/rn-protocol/accelerated-button-eventsfrom
kieran-osgood/05-21-feataddallprotocolevents
Open

feat(RN): Include remaining public protocol events from native#186
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/rn-protocol/accelerated-button-eventsfrom
kieran-osgood/05-21-feataddallprotocolevents

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 21, 2026

What changes are you making?

I've tophatted the ec.start event so far on a lower branch
This PR introduces the wiring for every other event - need to find test cases to detect each of the event cases

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 21, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 94%
93.75% (315/336) 88.29% (181/205) 100% (81/81)

@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 21, 2026 14:13
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 21, 2026 14:13
@kieran-osgood-shopify kieran-osgood-shopify changed the title feat: add all protocol events feat: Include remaining public protocol events from native May 21, 2026
@kieran-osgood-shopify kieran-osgood-shopify changed the title feat: Include remaining public protocol events from native feat(RN): Include remaining public protocol events from native May 21, 2026
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from 34e6ab2 to da83ecb Compare May 21, 2026 14:27
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch from 85fb866 to c0feec4 Compare May 21, 2026 14:27
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from da83ecb to 6edc610 Compare May 21, 2026 15:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch 2 times, most recently from 5136a10 to b94a9e1 Compare May 21, 2026 16:11
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from 6edc610 to 9b53f42 Compare May 21, 2026 16:11
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch from b94a9e1 to b20dc54 Compare May 22, 2026 08:26
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from 9b53f42 to 79075e4 Compare May 22, 2026 08:26
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch from b20dc54 to 7f01b0f Compare May 22, 2026 09:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch 2 times, most recently from 3b27e31 to b40a54d Compare May 22, 2026 10:18
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch from 7f01b0f to 75c217a Compare May 22, 2026 10:18
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from b40a54d to 2a2d61a Compare May 22, 2026 10:31
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch 2 times, most recently from 24d5341 to 6c05f67 Compare May 22, 2026 10:45
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from 2a2d61a to 3225a63 Compare May 22, 2026 10:45
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/rn-protocol/accelerated-button-events branch from 3225a63 to b62f5a4 Compare May 22, 2026 10:59
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-21-feataddallprotocolevents branch from 6c05f67 to 9ef73c7 Compare May 22, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants