catch more specific errors#189
Open
kiftio wants to merge 1 commit into
Open
Conversation
f944ed4 to
64de28d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Replaces broad
catch (e: Exception)blocks with specific exception types (SerializationException,NoSuchElementException,SecurityException) across the Android platform to avoid silently swallowing unexpected exceptions.CheckoutBridge: CatchesSerializationExceptionandNoSuchElementExceptionseparately, extracting the error notification logic into a sharednotifyDecodeFailurehelper.CheckoutProtocol: Narrows exception handling inerror,windowOpen, and checkout notification decoders, and refactorsClient.processto extractdecodeRequestwith a scopedSerializationExceptioncatch. ReplacesrunCatchingwith an explicittry/catchinTyped.dispatch.EmbeddedCheckoutProtocol: Replaces unsafejsonObject,jsonArray, andjsonPrimitiveextension property accesses (which throwIllegalArgumentException) with safeas?casts that throwSerializationExceptionon invalid structure, ensuring malformedec.readyparams are handled as parse errors.ExternalUriLauncher: Narrows the fallback catch toSecurityExceptiononly.CheckoutErrorDecoderandCheckoutCompletedEventDecoder: Replacecatch (e: Exception)withSerializationException(andNoSuchElementExceptionwhere applicable).A test is added to verify that an empty error payload body triggers
onCheckoutViewFailedWithError, and two new tests confirm that non-objectec.readyparams and a non-arraydelegatefield both produce a parse error response. A newExternalUriLauncherTestverifies that aSecurityExceptionfromstartActivityresults in aRejectedresult.How to test
./gradlew :lib:testCheckoutBridgeTest–should call onCheckoutViewFailedWithError if error payload is emptyEmbeddedCheckoutProtocolTest–ec ready with non-object params sends parse errorandec ready with non-array delegate sends parse errorExternalUriLauncherTest–launch rejects when startActivity throws security exceptionBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.