remove legacy-bridge#190
Open
kiftio wants to merge 1 commit into
Open
Conversation
e28dd67 to
a1f4480
Compare
a1f4480 to
151974b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Removes the legacy
CheckoutBridgeJS interface (registered under the"android"name) and replaces it entirely withEmbeddedCheckoutProtocolas the sole JavaScript interface attached toCheckoutWebView. As part of this:CheckoutBridge.ktand its associatedWebToSdkEventmodel are deleted.erroreventssubpackage (CheckoutErrorDecoder,CheckoutErrorGroup,CheckoutErrorPayload) is removed, along with the error-group-based exception mapping it performed.lifecycleeventssubpackage models (Address,CartInfo,CartLine,CartLineImage,CheckoutCompletedEvent,CheckoutCompletedEventDecoder,CompletedEvent,DeliveryDetails,DeliveryInfo,Discount,MoneyV2,OrderDetails,PaymentMethod,Price) are removed from the public API surface, as they are now generated from the protocol definition.ConfigurationExceptionandClientExceptionare removed from the documented exception hierarchy and error table.CheckoutExpiredExceptionerror codescart_completedandinvalid_cartare also removed.CheckoutWebViewListenerno longer holds atoggleHeadercallback, andCheckoutDialogno longer wires up header visibility toggling in response to modal events.CheckoutWebViewnow holds the listener directly rather than delegating throughCheckoutBridge.CheckoutBridge,CheckoutCompletedEventDecoder,CheckoutErrorDecoder, and the corresponding Java interop cases are removed.AGENTS.mdis updated to reflect the new architecture, replacing references toCheckoutBridgeand itsSCHEMA_VERSIONcontract withEmbeddedCheckoutProtocol.How to test
CheckoutBridgeor the removederrorevents/lifecycleeventsclasses../gradlew :lib:test) and confirm all remaining tests pass.CheckoutWebViewTestand verify the JavaScript interface assertions now referenceEmbeddedCheckoutProtocol.INTERFACE_NAME.MobileBuyIntegrationsample app and verify that checkout loads, completes, and surfaces errors correctly throughEmbeddedCheckoutProtocol.InteropTest.java) compiles and passes without the removed decoder tests.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.