Move Swift dev commands under root dev.yml#36
Merged
kyle-schellen merged 1 commit intoMay 13, 2026
Conversation
Contributor
Author
11 tasks
e2fdea2 to
dbc5438
Compare
f81f5e1 to
2f444c7
Compare
dbc5438 to
6e8f971
Compare
0c8370e to
11b5dd9
Compare
11b5dd9 to
93232df
Compare
markmur
approved these changes
May 11, 2026
f73c836 to
7d3dd73
Compare
93232df to
412dab9
Compare
11 tasks
7d3dd73 to
68173bf
Compare
94fc5d5 to
31fba85
Compare
68173bf to
e0453ab
Compare
31fba85 to
92ff28b
Compare
e0453ab to
ee59056
Compare
8d11dc5 to
d26f92e
Compare
ee59056 to
84d8099
Compare
d26f92e to
3b360d1
Compare
kieran-osgood-shopify
approved these changes
May 13, 2026
Base automatically changed from
05-08-move_android_dev_commands_under_root_dev.yml
to
main
May 13, 2026 14:51
3b360d1 to
cf9fc4b
Compare
11 tasks
Contributor
Author
Merge activity
|
kyle-schellen
added a commit
that referenced
this pull request
May 13, 2026
Refs issue #[908](shop/issues-checkout-kit#908). ### What changes are you making? Move `platforms/react-native/dev.yml` into namespaced commands at the repo root so `dev up` and `dev react-native <cmd>` (or `dev rn`) work from the monorepo root. Last in the stack after #35 (Android) and #36 (Swift). Also addresses review feedback to align RN with the Swift/Android shape: - Adds `s` alias for `server` - Drops the misleading `check` alias on `lint` (Android `check` has a larger surface; RN had no license-header check to back it) - Renames `fix` → `format` with `fix` kept as a legacy alias (matches the `dev <platform> format` convention) - Adds `dev rn build` so all three platforms expose a `build` subcommand - Updates `scripts/lint_swift` help text to point at the canonical `dev react-native format` ## How to test From the repo root: - `dev up` completes without error, including Node v22.14.0 / pnpm 10.33.1 setup, RN dependencies, gems, and pods - `dev rn build` builds the `@shopify/checkout-kit-react-native` module - `dev rn lint` runs SwiftLint/SwiftFormat checks, module lint, and sample lint - `dev rn style` still works as a legacy alias for `lint` - `dev rn lint swift`, `dev rn lint module`, and `dev rn lint sample` scope linting to one area - `dev rn format` auto-fixes Swift lint and format issues (SwiftLint + SwiftFormat) - `dev rn fix` still works as a legacy alias for `format` - `dev rn server` starts Metro - `dev rn s` still works as a short alias for `server` - `dev rn ios` runs the iOS sample app - `dev rn android` runs the Android sample app - `dev rn clean` wipes module + sample workspaces and stops `sccache` --- ### Before you merge > [!IMPORTANT] > > - [ ] I've added tests to support my implementation > - [ ] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md) > - [ ] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md) > - [ ] I've updated the relevant platform README (`platforms/swift/README.md` and/or `platforms/android/README.md`) --- <details> <summary>Releasing a new Swift version?</summary> - [ ] I have bumped the version in `platforms/swift/ShopifyCheckoutKit.podspec` - [ ] I have bumped the version in `platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift` - [ ] I have updated `platforms/swift/CHANGELOG.md` - [ ] I have updated the SwiftPM/CocoaPods version snippets in `platforms/swift/README.md` (major version only) </details> <details> <summary>Releasing a new Android version?</summary> - [ ] I have bumped the `versionName` in `platforms/android/lib/build.gradle` - [ ] I have updated `platforms/android/CHANGELOG.md` - [ ] I have updated the Gradle/Maven version snippets in `platforms/android/README.md` </details> > [!TIP] > See the [Contributing documentation](./CONTRIBUTING.md) for the full release process per platform.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Move swift/dev.yml into namespaced commands at the repo root so
dev upanddev swift <cmd>work from the monorepo root. Refs issue #908. React Native to follow upstack.How to test
From the repo root:
dev upcompletes without error, including Mint bootstrap, Xcode 26.2,Storefront.xcconfig, and entitlements setupdev swift lintrunsplatforms/swift/Scripts/lintdev swift stylestill works as a legacy alias forlintdev swift formatrunsplatforms/swift/Scripts/lint fixdev swift fixstill works as a legacy alias forformatdev swift buildbuilds the Swift package targetdev swift build packagesbuilds the Swift package targetdev swift build samplesbuilds the sample appsdev swift testruns the fullShopifyCheckoutKit-Packagetest suitedev swift test <ClassName>scopes the test run to one test classdev swift cleancleans Swift package build artifactsdev swift check license-headerschecks Swift license headersBefore you merge
Important
swift/README.mdand/orandroid/README.md)Releasing a new Swift version?
swift/ShopifyCheckoutKit.podspecswift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftswift/CHANGELOG.mdswift/README.md(major version only)Releasing a new Android version?
versionNameinandroid/lib/build.gradleandroid/CHANGELOG.mdandroid/README.mdTip
See the Contributing documentation for the full release process per platform.