Skip to content

Fix --alias to also match by userId for UUID-aliased sessions #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Mar 4, 2026
+12 −1
Merged

Fix --alias to also match by userId for UUID-aliased sessions #6933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/cli-kit/src/private/node/session/store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,17 @@ describe('session store', () => {
expect(result).toBeUndefined()
})

test('returns userId when alias matches userId directly', async () => {
// Given
vi.mocked(getSessions).mockReturnValue(JSON.stringify(mockSessions))

// When
const result = await findSessionByAlias('user1')

// Then
expect(result).toBe('user1')
})

test('returns first matching userId when multiple sessions have same alias', async () => {
// Given
const sessionsWithDuplicateAlias = {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-kit/src/private/node/session/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export async function findSessionByAlias(alias: string): Promise<string | undefi
if (!fqdnSessions) return undefined

for (const [userId, session] of Object.entries(fqdnSessions)) {
if (session.identity.alias === alias) {
if (session.identity.alias === alias || userId === alias) {
return userId
}
}
Expand Down
Loading