Skip to content

Use fixed stores for CLI E2E tests - #8949

Merged
isaacroldan merged 2 commits into
mainfrom
codex/e2e-persistent-stores
Oct 21, 2026
Merged

isaacroldan merged 2 commits into
mainfrom
codex/e2e-persistent-stores

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Creating and deleting a store for every app test adds provisioning delays and store-quota failures.

WHAT is this pull request doing?

Give each dev test a fixed reusable store and create a fresh app per test. Cleanup affects only that app and its preview; remote cleanup failures do not block store reuse. Keep one dedicated test for CLI store creation and deletion.

Concurrent runs can share stores without locks, but overlapping runs have not been stress-tested.

Keep Playwright's 20-minute suite limit. The CI job allows 30 minutes because setup, reports, and cleanup share the job; app cleanup is capped at five minutes.

How to manually test your changes?

Set E2E_STORE_FQDN in packages/e2e/.env to an accessible development store. Start app dev for two separate app projects in turn and confirm both can use that store while the first app remains installed.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Oct 19, 2026
@isaacroldan
isaacroldan added this pull request to stack #8950 October 19, 2026 13:50
@isaacroldan
isaacroldan removed this pull request from stack #8950 October 19, 2026 14:10
@isaacroldan
isaacroldan force-pushed the codex/e2e-persistent-stores branch from 5daa401 to 1dcbdb5 Compare October 19, 2026 14:11
@isaacroldan isaacroldan changed the title Reuse persistent stores in CLI E2E tests Use fixed stores for CLI E2E tests Oct 19, 2026
@isaacroldan
isaacroldan added this pull request to stack #8951 October 19, 2026 14:11
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/base-command.d.ts
@@ -21,7 +21,6 @@ declare abstract class BaseCommand extends Command {
     static descriptionWithoutMarkdown(): string | undefined;
     static analyticsNameOverride(): string | undefined;
     static analyticsStopCommand(): string | undefined;
-    private jsonOutputFromFlags;
     catch(error: Error & {
         skipOclifErrorHandling: boolean;
     }): Promise<void>;
@@ -37,7 +36,6 @@ declare abstract class BaseCommand extends Command {
     }, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
         argv: string[];
     }>;
-    protected runWithParsedOutput<T>(flags: FlagOutput, execute: () => T): T;
     protected environmentsFilename(): string | undefined;
     protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
     protected validateNonTTYFlags(flags: FlagOutput): void;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts
@@ -11,12 +11,5 @@ export declare abstract class ThemeManager {
     findOrCreate(name?: string, role?: Role): Promise<Theme>;
     fetch(name?: string, role?: Role): Promise<Theme | undefined>;
     generateThemeName(context: string): string;
-    create(themeRole?: Role, themeName?: string): Promise<{
-        createdAtRuntime: boolean;
-        id: number;
-        name: string;
-        processing: boolean;
-        role: string;
-        src?: string;
-    }>;
+    create(themeRole?: Role, themeName?: string): Promise<Theme>;
 }
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/metafield_definitions_by_owner_type.d.ts
@@ -2,14 +2,9 @@ import * as Types from './types.js';
 import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/core';
 export type MetafieldDefinitionsByOwnerTypeQueryVariables = Types.Exact<{
     ownerType: Types.MetafieldOwnerType;
-    after?: Types.InputMaybe<Types.Scalars['String']['input']>;
 }>;
 export type MetafieldDefinitionsByOwnerTypeQuery = {
     metafieldDefinitions: {
-        pageInfo: {
-            hasNextPage: boolean;
-            endCursor?: string | null;
-        };
         nodes: {
             key: string;
             name: string;

@isaacroldan
isaacroldan marked this pull request as ready for review October 20, 2026 08:30
@isaacroldan
isaacroldan requested a review from a team as a code owner October 20, 2026 08:30
@isaacroldan
isaacroldan force-pushed the codex/e2e-persistent-stores branch from 1dcbdb5 to 0edc788 Compare October 20, 2026 08:32
Base automatically changed from codex/e2e-parallel-store-cleanup to main October 21, 2026 12:01
Comment thread .github/workflows/tests-pr.yml Outdated
Comment thread packages/e2e/playwright.config.ts Outdated
@isaacroldan
isaacroldan force-pushed the codex/e2e-persistent-stores branch from 0edc788 to d52d5f1 Compare October 21, 2026 13:22
@isaacroldan
isaacroldan added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 21, 2026
@isaacroldan
isaacroldan added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 695b8cc Oct 21, 2026
28 of 29 checks passed
@isaacroldan
isaacroldan deleted the codex/e2e-persistent-stores branch October 21, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants