Repository navigation
Merge shop_scopes back into access_scopes.scopes when pulling app config - #8977
Merged
Merged
Conversation
maael
marked this pull request as ready for review
October 21, 2026 16:43
maael
force-pushed
the
fix-app-access-shop-scopes
branch
from
October 21, 2026 16:46
18fb773 to
5b347e7
Compare
isaacroldan
reviewed
Oct 22, 2026
isaacroldan
reviewed
Oct 22, 2026
| const AppAccessTransformConfig: CustomTransformationConfig = { | ||
| forward: (content) => appConfigTransform(content, AppAccessFieldMapping), | ||
| reverse: (content) => | ||
| appConfigTransform(mergeShopScopesIntoScopes(content as {[key: string]: unknown}), AppAccessFieldMapping, true), |
Contributor
There was a problem hiding this comment.
probably best to do the casting inside mergeShopScopesIntoScopes, but it's ok
isaacroldan
approved these changes
Oct 22, 2026
maael
force-pushed
the
fix-app-access-shop-scopes
branch
from
October 22, 2026 11:51
5b347e7 to
f95c113
Compare
maael
enabled auto-merge
October 22, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform stores Shop scopes in a separate shop_scopes field on the app_access module. The CLI's remote-to-local conversion only mapped scopes, so it dropped them. As a result, config link wrote TOMLs without Shop scopes, and the next deploy removed them, which can delete the app's Shop Server client on release. The deploy and release previews also hid the removal. This merges shop_scopes into access_scopes.scopes on the way down; the way up is unchanged.