Skip to content

Bump pinned Node versions to the Oct 21 security releases #8982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacroldan merged 1 commit into from
Oct 22, 2026
Merged

Bump pinned Node versions to the Oct 21 security releases #8982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gardener-backlog-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup deps
uses: ./.github/actions/setup-cli-deps
with:
node-version: '26.1.0'
node-version: '26.12.1'

- name: Create issue branch
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maintenance-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
if: steps.schedule.outputs.run == 'true'
uses: ./.github/actions/setup-cli-deps
with:
node-version: '26.1.0'
node-version: '26.12.1'

- name: Create maintenance branch
if: steps.schedule.outputs.run == 'true'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ jobs:
- name: Setup deps
uses: ./.github/actions/setup-cli-deps
with:
node-version: 24.12.0
node-version: 24.22.1
- name: Publish snapshot
id: publish
run: |
Expand Down Expand Up @@ -259,7 +259,7 @@ jobs:
- name: Setup deps
uses: ./.github/actions/setup-cli-deps
with:
node-version: 24.12.0
node-version: 24.22.1
- name: Create Release Pull Request
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1
Expand Down Expand Up @@ -363,7 +363,7 @@ jobs:
- name: Setup deps
uses: ./.github/actions/setup-cli-deps
with:
node-version: 24.12.0
node-version: 24.22.1
- name: Release
run: pnpm release ${{ github.event.inputs.tag || 'nightly' }}
env:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/tests-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
BUNDLE_WITHOUT: 'test:development'
GH_TOKEN: ${{ secrets.SHOPIFY_GH_READ_CONTENT_TOKEN }}
GH_TOKEN_SHOP: ${{ secrets.SHOP_GH_READ_CONTENT_TOKEN }}
DEFAULT_NODE_VERSION: '26.1.0'
DEFAULT_NODE_VERSION: '26.12.1'

jobs:
main:
Expand All @@ -32,7 +32,7 @@ jobs:
strategy:
matrix:
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest' ]
node: [ '22.12.0', '24.1.0', '26.1.0' ]
node: [ '22.23.4', '24.22.1', '26.12.1' ]
steps:
- uses: actions/checkout@v6
name: Checkout [${{ github.ref_name }}]
Expand All @@ -44,16 +44,16 @@ jobs:
node-version: ${{ matrix.node }}
- name: Build
run: pnpm nx run-many --all --target=build --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.12.1' }}
- name: Lint
run: pnpm nx run-many --all --target=lint --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.12.1' }}
- name: Type-check
run: pnpm nx run-many --all --target=type-check --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.12.1' }}
- name: Bundle
run: pnpm nx run-many --all --target=bundle --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.12.1' }}
- name: Unit tests
run: pnpm vitest run ${{ env.POOL_OPTIONS }}
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/tests-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ on:
node-version:
description: 'Node version'
required: true
default: '26.1.0'
default: '26.12.1'
type: choice
options:
- 22.12.0
- 24.1.0
- 26.1.0
- 22.23.4
- 24.22.1
- 26.12.1
os:
description: 'Operating system'
required: true
Expand All @@ -41,7 +41,7 @@ env:
SHOPIFY_FLAG_CLIENT_ID: ${{ secrets.SHOPIFY_FLAG_CLIENT_ID }}
GH_TOKEN: ${{ secrets.SHOPIFY_GH_READ_CONTENT_TOKEN }}
GH_TOKEN_SHOP: ${{ secrets.SHOP_GH_READ_CONTENT_TOKEN }}
DEFAULT_NODE_VERSION: '26.1.0'
DEFAULT_NODE_VERSION: '26.12.1'
DEFAULT_OS: 'ubuntu-latest'

jobs:
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ env:
BUNDLE_WITHOUT: 'test:development'
GH_TOKEN: ${{ secrets.SHOPIFY_GH_READ_CONTENT_TOKEN }}
GH_TOKEN_SHOP: ${{ secrets.SHOP_GH_READ_CONTENT_TOKEN }}
DEFAULT_NODE_VERSION: '26.1.0'
PLAYWRIGHT_NODE_VERSION: '24.1.0'
DEFAULT_NODE_VERSION: '26.12.1'
PLAYWRIGHT_NODE_VERSION: '24.22.1'

jobs:
type-check:
Expand Down Expand Up @@ -159,38 +159,38 @@ jobs:
strategy:
matrix:
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest' ]
node: [ '22.12.0', '24.1.0', '26.1.0' ]
node: [ '22.23.4', '24.22.1', '26.12.1' ]
shard: [ '' ]
include:
# Add sharding for Windows jobs to reduce wall-clock time
- os: windows-latest
node: '22.12.0'
node: '22.23.4'
shard: '1/2'
- os: windows-latest
node: '22.12.0'
node: '22.23.4'
shard: '2/2'
- os: windows-latest
node: '24.1.0'
node: '24.22.1'
shard: '1/2'
- os: windows-latest
node: '24.1.0'
node: '24.22.1'
shard: '2/2'
- os: windows-latest
node: '26.1.0'
node: '26.12.1'
shard: '1/2'
- os: windows-latest
node: '26.1.0'
node: '26.12.1'
shard: '2/2'
exclude:
# Exclude the non-sharded Windows entries (replaced by sharded ones above)
- os: windows-latest
node: '22.12.0'
node: '22.23.4'
shard: ''
- os: windows-latest
node: '24.1.0'
node: '24.22.1'
shard: ''
- os: windows-latest
node: '26.1.0'
node: '26.12.1'
shard: ''
steps:
- uses: actions/checkout@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-graphql-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Setup deps
uses: ./.github/actions/setup-cli-deps
with:
node-version: '26.1.0'
node-version: '26.12.1'
- name: Get schemas for codegen
env:
GH_TOKEN: ${{ secrets.SHOPIFY_GH_READ_CONTENT_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v26.1.0
v26.12.1
2 changes: 1 addition & 1 deletion dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: cli

up:
- node:
version: 26.1.0
version: 26.12.1
package_manager: pnpm@10.11.1
- packages:
- jq
Expand Down
Loading