Skip to content

Automated fix for refs/heads/rwstauner/ares-resolver-fork-crash #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: rwstauner/ares-resolver-fork-crash
Choose a base branch
from
Open

Automated fix for refs/heads/rwstauner/ares-resolver-fork-crash #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions CMakeLists.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions build_autogenerated.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 4 additions & 7 deletions test/core/event_engine/posix/ares_resolver_fork_safety_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,16 @@ TEST_F(AresResolverTest, ResetThenOrphanDoesNotCrash) {
//
// This is a more realistic scenario: the resolver has active DNS queries
// when the fork handler fires and tears things down.
TEST_F(AresResolverTest,
ResetThenOrphanWithPendingLookupsDoesNotCrash) {
TEST_F(AresResolverTest, ResetThenOrphanWithPendingLookupsDoesNotCrash) {
auto dns_server = DnsServer::Start(grpc_pick_unused_port_or_die());
ASSERT_TRUE(dns_server.ok()) << dns_server.status();

auto ee = std::static_pointer_cast<PosixEventEngine>(GetDefaultEventEngine());
auto* poller = GetPoller(ee.get());

auto ares_resolver = AresResolver::CreateAresResolver(
dns_server->address(),
std::make_unique<GrpcPolledFdFactoryPosix>(poller), ee);
dns_server->address(), std::make_unique<GrpcPolledFdFactoryPosix>(poller),
ee);
ASSERT_TRUE(ares_resolver.ok()) << ares_resolver.status();

auto reinit_handle = ares_resolver->get()->GetReinitHandle().lock();
Expand All @@ -131,9 +130,7 @@ TEST_F(AresResolverTest,

#else // GRPC_ENABLE_FORK_SUPPORT

TEST(AresResolverTest, Skipped) {
GTEST_SKIP() << "Fork support is disabled";
}
TEST(AresResolverTest, Skipped) { GTEST_SKIP() << "Fork support is disabled"; }

#endif // GRPC_ENABLE_FORK_SUPPORT

Expand Down
22 changes: 22 additions & 0 deletions tools/run_tests/generated/tests.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.