Repository navigation
Fix invalid UTF-8 handling in vendored SQLite parser - #50
Merged
tszymczyszyn-shopify merged 1 commit intoOct 7, 2026
Merged
tszymczyszyn-shopify merged 1 commit into
tszymczyszyn-shopify merged 1 commit into
Conversation
Port gwenn/lemon-rs@14f422a to replace the unchecked UTF-8 conversion with a lossy conversion. Bump the vendored parser to 0.13.1 and add regression coverage for invalid input.\n\nAddresses CVE-2025-47736 / GHSA-8m95-fffc-h4c5.
AryanSuvarna
approved these changes
Oct 6, 2026
sle-c
approved these changes
Oct 6, 2026
tszymczyszyn-shopify
merged commit Oct 7, 2026
f06c62c
into
v0.9.30-shopify-patches
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite3-parserinvalid UTF-8 fix fromgwenn/lemon-rs@14f422aString::from_utf8_lossylibsql-sqlite3-parserpackage from 0.13.0 to 0.13.1Why
libsql-sqlite3-parser0.13.0 is affected by GHSA-8m95-fffc-h4c5 / CVE-2025-47736. The parser accepts byte slices, butfrom_bytesconstructed astrwithout validating that those bytes were UTF-8.The original parser project fixed this in May 2025, but libsql's vendored copy still contains the vulnerable implementation. Versioning the patched vendored package as 0.13.1 also places it outside the advisory's affected range (
<=0.13.0) for downstream lockfiles.The related upstream libsql report is tursodatabase/libsql#2052.
Test plan
cargo +1.98.1 fmt --all -- --checkcargo +1.98.1 test -p libsql-sqlite3-parser --lockedcargo +1.98.1 check -p libsql-sqlite3-parser --all-targets --all-features --lockedgit diff --check