Repository navigation
Validate heap profile IDs in admin API - #52
Merged
tszymczyszyn-shopify merged 4 commits intoOct 8, 2026
Merged
tszymczyszyn-shopify merged 4 commits into
tszymczyszyn-shopify merged 4 commits into
Conversation
tszymczyszyn-shopify
merged commit Oct 8, 2026
5e100d7
into
v0.9.30-shopify-patches
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Heap profile IDs are used to construct local paths by the disable and delete admin handlers. Treat the ID returned by Rheaper as an opaque basename rather than depending on Rheaper's private
rip-<timestamp>naming convention.What changed
InvalidPathresponse (400 Bad Request) for unsafe IDsTest plan
cargo fmt --all -- --checkcargo check -p libsql-server --libcargo test -p libsql-server http::admin::tests --lib(5 passed, including a live enable→disable round trip)The targeted test link required temporarily omitting the existing
pcre2_internal.hcompiler input on macOS; that unrelated workaround is not included in this change.