Merged
Conversation
pushrax
approved these changes
Feb 19, 2021
4872386 to
5850f73
Compare
Contributor
|
I'm seeing a test failure in Liquid here when combined with this branch assert_template_result('2', '{{ list[foo] }}', 'foo' => IntegerDrop.new('1'), 'list' => [1, 2, 3])This looks unrelated, though. Perhaps a bug on main? |
Contributor
|
This may also be because the branches are out of date, checking that now. |
5850f73 to
e56cbf9
Compare
samdoiron
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adding a
#inline comment tag for Shopify/liquid#1393 requires changing the parsing code to recognize that as a tag.Solution
Change the code path for where no word characters are found for tag name, so this shouldn't even impact the performance of handling non-comment tags.