Respect disable_liquid_c_nodes when parsing expressions#154
Merged
dylanahsmith merged 1 commit intomasterfrom Aug 31, 2021
Merged
Respect disable_liquid_c_nodes when parsing expressions#154dylanahsmith merged 1 commit intomasterfrom
dylanahsmith merged 1 commit intomasterfrom
Conversation
macournoyer
approved these changes
Aug 17, 2021
samdoiron
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samdoiron pointed out that I hadn't gotten around to having expression parsing respect the
disable_liquid_c_nodes: trueparse option. This can be problematic when parsing liquid for some type of static analysis in the same program that also uses liquid-c, since it prevents liquid-c from being dynamically disabled just for that static analysis.I had already made the necessary change to liquid in Shopify/liquid#1333 so that expressions could be parsed through the parse context. This PR makes the corresponding liquid-c change that overrides Liquid::ParseContext#parse_expression to make using Liquid::C::Expression conditional on the presence of the
disable_liquid_c_nodesparse option.