Repository navigation
Add range resource-limit regression specs - #165
Merged
Merged
Conversation
Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared regression coverage for the range resource accounting in Shopify/liquid#2117.
Nine output cases were captured from the Liquid tests using the existing
ShopifyLiquidPatchimporter. Ten bounded resource-limit cases cover empty and nonempty loops, cumulative partials, offsets, reversal, metadata, captures, andtablerowclosing markup. Allocation guards, exact counter assertions, repeated-render state, and customRangesubclass behavior remain Ruby tests because the YAML format can't express those checks.The resource cases use a staged
range_resource_limitscapability. Built-in v5.13 reference adapters and generated JSON-RPC adapters opt out. After this PR merges, Shopify/liquid#2117 will pin the merged liquid-spec revision and run the staged cases through its own adapters.This also fixes Range capture so exclusive and endless endpoints survive YAML round trips. Inclusive ranges keep their existing two-item encoding.
In a clean v5.13 checkout, the pre-push gate passes and the reference adapter runs the nine imported cases while skipping the staged capability. A separate local run against Shopify/liquid#2117 passes all ten staged cases; the pre-fix Liquid baseline fails the four accounting regressions.
Depends on the CI baseline merged in #164.