Merged
Conversation
d3da046 to
b1e0db9
Compare
shioyama
reviewed
Jul 29, 2021
| true | ||
| module LocalCacheDup | ||
| def with_local_cache | ||
| use_temporary_local_cache(LocalStore.new) { yield } |
Member
There was a problem hiding this comment.
These changes are not applied when Rails assigns LocalStore in middleware here:
LocalCacheRegistry.set_cache_for(local_cache_key, LocalStore.new)This means that duping is broken for middleware-applied LocalCache when memcached_store is used, since the duping fixes above are not present in ActiveSupport::Cache::Strategy::LocalCache::LocalStore.
Contributor
There was a problem hiding this comment.
Yup. I'll need to use a decorator or something like that instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following rails/rails#42649 we need to make some small changes to fix
with_local_store.Now ActiveSupport use the local store as a "payload" store (e.g. it contain serialized payloads instead of
Entryinstance). Both upstreamMemCacheStoreandMemcachedStoredon't play so well with this new architecture, because they directly passEntryinstance to the underlying client.So we basically need to backport the old local store behavior that was duping the cache entry to avoid leaks.
Longer term we should migrate to the new architecture where we no longer rely on
memcachedserializing objects for us (See: #63).