Add hover information on associations#616
Merged
vinistock merged 1 commit intoShopify:mainfrom Jul 17, 2025
Merged
Conversation
Contributor
|
I only saw this after opening #630, so just a heads up that through association support would be good to add here if that gets merged first. |
vinistock
reviewed
Jul 16, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
This is looking good. For whatever reason, this PR's CI is also stuck. Can you please rebase?
domingo2000
force-pushed
the
add-hover-on-associations
branch
from
3929b61 to
bb69c81
Compare
domingo2000
force-pushed
the
add-hover-on-associations
branch
from
bb69c81 to
5c5ad8e
Compare
Contributor
Author
|
Just rebased and passed CI. But windows builds are still failing for some reason 😞 . |
vinistock
approved these changes
Jul 17, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
@joshuay03 if you're interested in following up with the through support, please put up another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #476
Add class information on hover in the associations for models.
We provide the same information that hover on constants provide, but in the symbol of the associations.