Make trigger_reload return success/failure status#691
Draft
Conversation
Change reload from a fire-and-forget notification to a request that
returns { success: true/false }. This allows callers (like the Tapioca
addon) to skip DSL generation when reload fails, instead of running
against stale server state.
Server: catch StandardError during reload!, return success status.
Client: use make_request instead of send_notification.
Related: Shopify/team-ruby-dx#1711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
reloadfrom a fire-and-forget notification to a request that returns{ success: true/false }. This allows callers (like the Tapioca addon) to know whether reload succeeded and skip DSL generation when it fails, instead of running against stale server state and producing incorrect RBIs.Changes
server.rb: Thereloadhandler now catchesStandardErrorfromRails.application.reloader.reload!and returns{ success: true }or{ success: false }viasend_resultrunner_client.rb:trigger_reloadusesmake_requestinstead ofsend_notification, returning the result hash to callersTesting
reloadhandler sent no result — callers had no way to detect failure{ success: true }on successRelated