Skip to content

Prevent workspace_dependencies failing if directory gets removed during execution #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinistock wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent workspace_dependencies failing if directory gets removed during execution #3980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_lsp/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,7 @@ def workspace_dependencies(message)
}
end
end
rescue Bundler::GemNotFound, Bundler::GemfileNotFound
rescue Bundler::GemNotFound, Bundler::GemfileNotFound, Errno::ENOENT
[]
end

Expand Down
18 changes: 18 additions & 0 deletions test/server_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,24 @@ def test_workspace_dependencies_does_not_fail_if_gems_are_not_installed
assert_empty(@server.pop_response.response)
end

def test_workspace_dependencies_returns_empty_response_when_cwd_is_deleted
original_dir = Dir.pwd

begin
parent = Dir.mktmpdir
workspace = File.join(parent, "workspace")
Dir.mkdir(workspace)
Dir.chdir(workspace)
FileUtils.rm_rf(parent)

@server.process_message({ id: 1, method: "rubyLsp/workspace/dependencies" })

assert_empty(@server.pop_response.response)
ensure
Dir.chdir(original_dir)
end
end

def test_workspace_dependencies_returns_empty_list_when_there_is_no_bundle
@server.global_state.expects(:top_level_bundle).returns(false)
@server.process_message({ id: 1, method: "rubyLsp/workspace/dependencies" })
Expand Down