Open
Conversation
6 tasks
Maras0830
approved these changes
Jun 26, 2023
Maras0830
left a comment
Maras0830
left a comment
There was a problem hiding this comment.
This PR is helpful, I also adjusted the code like this
nilsringersma
left a comment
nilsringersma
left a comment
There was a problem hiding this comment.
Hi @rafaelstz , I was working on implementing trial days and came across this PR. I like the approach and it works great. Small issue with assigning the key/value pairs in the arrays inside the Ensurebilling class. Please see the suggestions.
Thanks!
Co-authored-by: Nils Ringersma <nilsringersma@gmail.com>
Co-authored-by: Nils Ringersma <nilsringersma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
It's adding 7 trial days as part of the example recurrent and one-time charge.
Checklist
Note: once this PR is merged, it becomes a new release for this template.
README.mdfile and other related documentation, if applicable