Merged
Conversation
d24373f to
cd1414a
Compare
saga-dasgupta
approved these changes
Feb 5, 2026
Contributor
saga-dasgupta
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test helpers fail on Windows because
child_process.spawn()cannot resolve.cmdfiles (which npm uses for executables on Windows). This causes the library to fail when trying to execute the Shopify CLI on Windows systems. (#46)Solution
Shopify CLI also has cross-platform requirements, so I looked at that repo for a solution. Instead of using
spawn, it instead uses execa.This PR migrates us from
child_process.spawntoexeca(version 7.2.0, matching Shopify CLI).Changes
Implementation
execa@^7.2.0topackage.jsonbuild-function.ts: Replaced spawn with execa, maintained exact error message compatibilityget-function-info.ts: Replaced spawn with execa, maintained exact error message compatibilityTests
Tophat 🎩
pnpm installpnpm pack-> should give you a tarball.node_modulesof the app/function contains the updatedexecausing code.npx vitest runAlternative
We could pass the shell arg to
spawnwhen on windows, #47