Skip to content

Avoid duplicating definition of ActiveRecord::Relation.destroy_all #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid duplicating definition of ActiveRecord::Relation.destroy_all #2537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tapioca/dsl/compilers/active_record_relations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ def create_common_methods
create_common_method(
"destroy_all",
return_type: "T::Array[#{constant_name}]",
)
) unless RELATION_METHODS.include? :destroy_all
Copy link
Copy Markdown
Contributor

@KaanOzkan KaanOzkan Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to remove this completely, looks like it's been there since Rails 3. So I don't see how this include? will fail for Tapioca's Rails > 8.0 requirement.

create_common_method(
  "destroy_all",
  return_type: "T::Array[#{constant_name}]",
)


FINDER_METHODS.each do |method_name|
case method_name
Expand Down
6 changes: 0 additions & 6 deletions spec/tapioca/dsl/compilers/active_record_relations_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,6 @@ def destroy(*records); end
sig { returns(T::Array[::Post]) }
def destroy_all; end

sig { returns(T::Array[::Post]) }
def destroy_all; end

sig { params(args: T.untyped).returns(T::Array[::Post]) }
def destroy_by(*args); end

Expand Down Expand Up @@ -854,9 +851,6 @@ def destroy(*records); end
sig { returns(T::Array[::Post]) }
def destroy_all; end

sig { returns(T::Array[::Post]) }
def destroy_all; end

sig { params(args: T.untyped).returns(T::Array[::Post]) }
def destroy_by(*args); end

Expand Down
Loading