Skip to content

Use Rubydex graph for constants_from_requested_paths #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Morriar wants to merge 1 commit into
base: at-rubydex-bootstrap
Choose a base branch
from
Open

Use Rubydex graph for constants_from_requested_paths #2608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tapioca/commands/abstract_dsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def generate_command_for(constant)
#: -> Array[String]
def constants_from_requested_paths
@constants_from_requested_paths ||=
Static::SymbolLoader.symbols_from_paths(@requested_paths).to_a #: Array[String]?
Static::SymbolLoader.graph_from_paths(@requested_paths).declarations.map(&:name) #: Array[String]?
end
end
end
Expand Down
16 changes: 0 additions & 16 deletions lib/tapioca/static/symbol_loader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,22 +60,6 @@ def engine_symbols(gem)
Set.new
end

#: (Array[Pathname] paths) -> Set[String]
def symbols_from_paths(paths)
return Set.new if paths.empty?

output = Tempfile.create("sorbet") do |file|
file.write(Array(paths).join("\n"))
file.flush

symbol_table_json_from("@#{file.path.shellescape}")
end

return Set.new if output.empty?

SymbolTableParser.parse_json(output)
end

private

# @without_runtime
Expand Down
Loading